Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract tests related to event-logging into separate file #8733

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

hendrikmakait
Copy link
Member

Precursor to #8731

  • Tests added / passed
  • Passes pre-commit run --all-files

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±0      29 suites  ±0   11h 31m 0s ⏱️ - 1m 28s
 4 064 tests ±0   3 961 ✅ +4     97 💤 ±0  6 ❌  - 4 
55 981 runs  ±0  53 811 ✅ +6  2 163 💤 ±0  7 ❌  - 6 

For more details on these failures, see this check.

Results for commit 9b14d5a. ± Comparison against base commit 97dbdaa.

This pull request removes 12 and adds 12 tests. Note that renamed tests count towards both.
distributed.tests.test_client ‑ test_events_all_servers_use_same_channel
distributed.tests.test_client ‑ test_events_subscribe_topic
distributed.tests.test_client ‑ test_events_subscribe_topic_cancelled
distributed.tests.test_client ‑ test_events_unsubscribe_raises_if_unknown
distributed.tests.test_client ‑ test_log_event
distributed.tests.test_client ‑ test_log_event_msgpack
distributed.tests.test_client ‑ test_log_event_multiple_clients
distributed.tests.test_client ‑ test_log_event_warn
distributed.tests.test_client ‑ test_log_event_warn_dask_warns
distributed.tests.test_nanny ‑ test_log_event
…
distributed.tests.test_client ‑ test_warn_manual
distributed.tests.test_client ‑ test_warn_remote
distributed.tests.test_event_logging ‑ test_configurable_events_log_length
distributed.tests.test_event_logging ‑ test_events_all_servers_use_same_channel
distributed.tests.test_event_logging ‑ test_events_subscribe_topic
distributed.tests.test_event_logging ‑ test_events_subscribe_topic_cancelled
distributed.tests.test_event_logging ‑ test_events_unsubscribe_raises_if_unknown
distributed.tests.test_event_logging ‑ test_log_event
distributed.tests.test_event_logging ‑ test_log_event_msgpack
distributed.tests.test_event_logging ‑ test_log_event_multiple_clients
…

Copy link
Collaborator

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hendrikmakait hendrikmakait merged commit 0c58545 into dask:main Jun 26, 2024
29 of 36 checks passed
@hendrikmakait hendrikmakait deleted the extract-log-event-tests branch June 26, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants