Cache URL encoding of worker addresses in dashboard #8725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ± 0 29 suites ±0 11h 34m 51s ⏱️ + 7m 20s For more details on these failures, see this check. Results for commit b71a030. ± Comparison against base commit f925766. ♻️ This comment has been updated with latest results. |
jrbourbeau
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Nice, LGTM @fjetter
I'm curious what this PR does to the idle dashboard performance you were looking at
Co-authored-by: James Bourbeau <[email protected]>
|
Sorry, there was a linting error in the code suggestion I made : / Pushed a commit to make pre-commit happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently looked at a scheduler profile of a large-ish cluster (~300 workers) and noticed that the scheduler CPU is utilized up to 20% with an idle cluster once the dashboard is enabled.
Most of this turned out to be the occupancy, tasks, memory, etc. view per worker and I found a couple of hotspots.
I also noticed how
_expects_commis taking up a nontrivial time and can be cached.