Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable export substitution for _version.py #8709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Jun 20, 2024

I'm not sure why this was missed, but when you install versioneer, it adds these attributes so that things like version/commit hash/etc. are correct when you make a git archive. Without this substitution, test_git_revision fails because there is no revision info in the archive tarball.

  • Tests added / passed
  • Passes pre-commit run --all-files

I'm not sure why this was missed, but when you install versioneer, it
adds these attributes so that things like version/commit hash/etc. are
correct when you make a git archive. Without this substitution,
`test_git_revision` fails because there is no revision info in the
archive tarball.
@QuLogic QuLogic requested a review from fjetter as a code owner June 20, 2024 05:52
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    29 files  ±    0      29 suites  ±0   10h 11m 57s ⏱️ - 1h 20m 22s
 4 066 tests +    5   3 945 ✅  -    16    106 💤 +  9  11 ❌ +8   4 🔥 + 4 
48 342 runs   - 7 597  46 398 ✅  - 7 374  1 915 💤  - 248  12 ❌ +8  17 🔥 +17 

For more details on these failures and errors, see this check.

Results for commit e135b0a. ± Comparison against base commit aeebb2d.

This pull request removes 8 and adds 13 tests. Note that renamed tests count towards both.
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_scheduler_report_args[report_args0]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[1]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers[True]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[False]
distributed.diagnostics.tests.test_memray ‑ test_basic_integration_workers_report_args[report_args0]
distributed.protocol.tests.test_arrow
distributed.protocol.tests.test_collection
distributed.protocol.tests.test_highlevelgraph
distributed.protocol.tests.test_numpy
distributed.protocol.tests.test_pandas
distributed.shuffle.tests.test_graph
distributed.shuffle.tests.test_merge
distributed.shuffle.tests.test_merge_column_and_index
distributed.shuffle.tests.test_metrics
distributed.shuffle.tests.test_rechunk
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant