Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Asynchronous SpillBuffer #7686

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Asynchronous SpillBuffer #7686

wants to merge 2 commits into from

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Mar 20, 2023 •
edited
Loading

This was referenced Mar 21, 2023
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2023 •
edited
Loading

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       26 files  +       1         26 suites  +1   14h 20m 14s ⏱️ + 32m 50s
  3 545 tests ±       0    3 407 ✔️  -      29     106 💤 ±    0    22 ❌ +  19  10 🔥 +10 
44 845 runs  +2 222  42 448 ✔️ +1 939  2 236 💤 +125  123 ❌ +120  38 🔥 +38 

For more details on these failures and errors, see this check.

Results for commit 2114a7b. ± Comparison against base commit 7511cf5.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky force-pushed the async_buffer branch 7 times, most recently from 8296896 to 9f5898b Compare March 28, 2023 14:48
@crusaderky crusaderky self-assigned this Mar 28, 2023
@crusaderky crusaderky force-pushed the async_buffer branch 4 times, most recently from 3f20267 to 1075ea5 Compare March 29, 2023 14:09
@crusaderky crusaderky mentioned this pull request Mar 30, 2023
Open
@crusaderky crusaderky force-pushed the async_buffer branch 7 times, most recently from 68b8306 to 7ae9f0e Compare April 3, 2023 13:37
@crusaderky crusaderky reopened this Apr 3, 2023
@crusaderky crusaderky mentioned this pull request Apr 5, 2023
Merged
@crusaderky crusaderky reopened this Apr 6, 2023
@crusaderky
Copy link
Collaborator Author

This is postponed indefinitely following disappointing A/B test results - see main issue.

@crusaderky crusaderky mentioned this pull request Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjetter fjetter Awaiting requested review from fjetter fjetter will be requested when the pull request is marked ready for review fjetter is a code owner

Assignees

@crusaderky crusaderky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asynchronous Disk Access in Workers
1 participant
@crusaderky