Skip to content

Commit

Permalink
Adjust popen timeouts for testing (#8848)
Browse files Browse the repository at this point in the history
  • Loading branch information
fjetter authored Oct 29, 2024
1 parent afa6e8d commit 09ed8af
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion distributed/tests/test_jupyter.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ def test_jupyter_cli(loop):
"--host",
f"127.0.0.1:{port}",
],
capture_output=True,
):
with Client(f"127.0.0.1:{port}", loop=loop):
response = requests.get("http://127.0.0.1:8787/jupyter/api/status")
Expand Down
4 changes: 2 additions & 2 deletions distributed/utils_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -1138,8 +1138,8 @@ def _terminate_process(proc: subprocess.Popen, terminate_timeout: float) -> None
def popen(
args: list[str],
capture_output: bool = False,
terminate_timeout: float = 30,
kill_timeout: float = 10,
terminate_timeout: float = 10,
kill_timeout: float = 5,
**kwargs: Any,
) -> Iterator[subprocess.Popen[bytes]]:
"""Start a shell command in a subprocess.
Expand Down

0 comments on commit 09ed8af

Please sign in to comment.