Fix: Mismatch between declared CRDs and struct for DaskAutoscalers #894
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a mismatch identified between the declared Custom Resource Definitions (CRDs) for Kubernetes resources and the
DaskAutoscalerSpec
struct in the Go client.Problem
The issue lies with the
minimum
andmaximum
attributes in theDaskAutoscalerSpec
struct, which were initially declared asstring
types but should beint
, as declared in the CRDs. This disparity causes issues between the Go client and the registered Kubernetes scheme.Solution
I have resolved this bug by altering the
DaskAutoscalerSpec
struct to useint
for themax
andmin
attributes, ensuring consistency with the CRD. Subsequently, I ran the code autogeneration script to validate that there are no adverse side-effects from these changes.Thank you for your consideration.