Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python-box compatability (#848) #858

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fix python-box compatability (#848) #858

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef8ee8
Fix python-box compatability (#848)
dbalabka Feb 5, 2024
5c9e506
Merge branch 'main' of github.com:dask/dask-kubernetes into patch-4
jacobtomlinson Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dask_kubernetes/operator/networking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ async def get_external_address_for_scheduler_service(
def _get_port(service, port_name, is_node_port=False):
"""NodePort is a special case when we have to use node_port instead of node"""
[port] = [
port.port if not is_node_port else port.node_port
port.port if not is_node_port else port.nodePort
for port in service.spec.ports
if port.name == service.metadata.name or port.name == port_name
]
Expand Down
Loading