Scale Dask worker group from Cluster spec #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtomlinson
approved these changes
May 24, 2023
Comment on lines
+492
to
+504
| async with kubernetes.client.api_client.ApiClient() as api_client: | ||
| custom_objects_api = kubernetes.client.CustomObjectsApi(api_client) | ||
| custom_objects_api.api_client.set_default_header( | ||
| "content-type", "application/merge-patch+json" | ||
| ) | ||
| await custom_objects_api.patch_namespaced_custom_object_scale( | ||
| group="kubernetes.dask.org", | ||
| version="v1", | ||
| plural="daskworkergroups", | ||
| namespace=namespace, | ||
| name=worker_group_name, | ||
| body={"spec": {"replicas": new}}, | ||
| ) |
There was a problem hiding this comment.
I'm excited about the kr8s changes in #696 because this will be hugely simplified.
Suggested change
| async with kubernetes.client.api_client.ApiClient() as api_client: | |
| custom_objects_api = kubernetes.client.CustomObjectsApi(api_client) | |
| custom_objects_api.api_client.set_default_header( | |
| "content-type", "application/merge-patch+json" | |
| ) | |
| await custom_objects_api.patch_namespaced_custom_object_scale( | |
| group="kubernetes.dask.org", | |
| version="v1", | |
| plural="daskworkergroups", | |
| namespace=namespace, | |
| name=worker_group_name, | |
| body={"spec": {"replicas": new}}, | |
| ) | |
| worker_group = await DaskWorkerGroup.get(worker_group_name) | |
| await worker_group.scale(new) |
Happy to merge this as-is though and I'll update it in a follow-up once kr8s is integrated nicely.
There was a problem hiding this comment.
Oh, wow! Definitely looking forward to that!
Comment on lines
179
to
185
| k8s_cluster.kubectl( | ||
| "scale", | ||
| "--replicas=3", | ||
| "daskcluster.kubernetes.dask.org", | ||
| cluster_name, | ||
| ) | ||
| await client.wait_for_workers(3) |
There was a problem hiding this comment.
This wont actually test anything because client.wait_for_workers(3) will just pass when there are 5 workers.
I opened dask/distributed#6377 a while ago to allow you to modify the behaviour for cases like this. I should nudge that PR along.
Maybe we should have a TODO comment here so that we come back and fix it up later.
jacobtomlinson
approved these changes
May 24, 2023
|
Looks like CI is failing. Looking into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #636. This PR adds another handler that scales the default worker group when the
worker.replicasfield of the cluster spec is changed.