[WIP] add execplugin support for AutoRefreshKubeConfigLoader #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for raising this. It generally looks good to me, although I am unfamiliar with the exec method for authentication so am unable to test locally.
The auth section of dask-kubernetes is not well tested today. Tests use kind and auth via a token so much of this code isn'y covered. @gregoiregermain do you have any thoughts on how we could more robustly test things here?
|
Sorry we never got to merging this. The project has changed a lot since this was raised so going to close it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #388
@jacobtomlinson This should adapt AutoRefreshKubeConfigLoader to support execPlugin authentification method.