Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AutoRefreshKubeConfigLoader ExecPlugin support #388

Closed
gregoiregermain opened this issue Jan 21, 2022 · 4 comments
Closed

Enable AutoRefreshKubeConfigLoader ExecPlugin support #388

gregoiregermain opened this issue Jan 21, 2022 · 4 comments

Comments

@gregoiregermain
Copy link

Related to #317

Current behavior

The AutoRefreshKubeConfigLoader overwrites KubeConfigLoader following methods:

  • _load_oid_token
  • load_gcp_token

Get the expiration timestamp of the provided token and create a task than run before the token expiration.
The user authentification method with an executable:

"exec" in self._user

is not supported and the warning in the refresh_after method is not logged because the kubernetes_asyncio KubeConfigLoader._load_from_exec_plugin is not overwritten.

Desired Behavior

We should be able to get the expiration timestamp from the response of the executable and use it to make the auto refresh supporting executable plugin authentification method.

@jacobtomlinson
Copy link
Member

Thanks for reporting this. Do you have any interest in raising a Pull Request?

@gregoiregermain
Copy link
Author

Yes sure!

@YeppoonYIN
Copy link

Hi, any updates on the pull request? I think the default kube config generated by GKE is using exec now. This will be really helpful for new users.

@jacobtomlinson
Copy link
Member

The classic KubeCluster was removed in #890. All users will need to migrate to the Dask Operator. Closing.

@jacobtomlinson jacobtomlinson closed this as not planned Won't fix, can't repro, duplicate, stale Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants