Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add no_dispatch to dask_method #429

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Dec 2, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dd3267a) 93.21% compared to head (fa2cf28) 93.22%.

Files Patch % Lines
src/dask_awkward/lib/core.py 96.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   93.21%   93.22%           
=======================================
  Files          23       23           
  Lines        3168     3187   +19     
=======================================
+ Hits         2953     2971   +18     
- Misses        215      216    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agoose77
Copy link
Collaborator Author

agoose77 commented Dec 2, 2023

@lgray give this a spin and let us know!

@lgray
Copy link
Collaborator

lgray commented Dec 2, 2023

Looks good from my side - please merge!

@lgray
Copy link
Collaborator

lgray commented Dec 2, 2023

A release would be appreciated as well.

@douglasdavis
Copy link
Collaborator

Looks like this is a good to go in?

@lgray
Copy link
Collaborator

lgray commented Dec 5, 2023

yes, please!

@douglasdavis douglasdavis merged commit daf0dbe into main Dec 5, 2023
25 checks passed
@douglasdavis douglasdavis deleted the agoose77/feat-add-no-dispatch-method branch December 5, 2023 22:31
@douglasdavis
Copy link
Collaborator

Cool- 2023.12.0 on PyPI momentarily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants