fix: support logical concatenation at axis=0
#425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasdavis
force-pushed
the
agoose77/fix-concat-axis-0
branch
from
3552a4d
to
312cc2b
Compare
douglasdavis
reviewed
Dec 7, 2023
| for i, k in enumerate( | ||
| k for collection in arrays for k in collection.__dask_keys__() | ||
| ) | ||
| } |
There was a problem hiding this comment.
I did not know this level of list/dict comprehension existed 🤯
douglasdavis
approved these changes
Dec 7, 2023
douglasdavis
force-pushed
the
agoose77/fix-concat-axis-0
branch
from
312cc2b
to
969427e
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
==========================================
- Coverage 93.22% 92.96% -0.27%
==========================================
Files 23 23
Lines 3187 3197 +10
==========================================
+ Hits 2971 2972 +1
- Misses 216 225 +9 ☔ View full report in Codecov by Sentry. |
douglasdavis
pushed a commit
to douglasdavis/dask-awkward
that referenced
this pull request
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends upon scikit-hep/awkward#2862, scikit-hep/awkward#2860
Fixes #305.