refactor: enforce more type hints #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agoose77
requested review from
douglasdavis
and removed request for
douglasdavis
| "This function is not necessary in the context of dask-awkward." | ||
| ) | ||
| def copy(array: Array) -> Array: | ||
| return array | ||
|
|
There was a problem hiding this comment.
This could be a little confusing, no? Folks might expect to get a new object
There was a problem hiding this comment.
This change should have been louder and/or had a review from you, sorry.
My rationale is that we want ak.XXX to work on both ak and dak Array objects. Thus, we should still support the function. However, I now realise that with the way that coffea (ab)uses behavior, and now with attrs, we'll need to perform a shall copy. Let me make a new PR.
Otherwise, are you happy with this rationale?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to enforce some more type hints