feat!: add Scalar binary and unary ops; adjust Scalar.__getattr__
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #397 +/- ##
==========================================
+ Coverage 93.87% 94.04% +0.16%
==========================================
Files 23 23
Lines 3022 3055 +33
==========================================
+ Hits 2837 2873 +36
+ Misses 185 182 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for binary and unary operations with the
Scalarcollection, fixing #396It also changes the existing
__getattr__implementation on theScalarobject. It was there to support any kind of Python Scalar object by just converting to delayed, but having this breaks IPython. We should raise an error that instructs the user to convert to delayed.