chore: add main API functions & classes to top level __init__.py
#331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasdavis
changed the title
__init__.py__init__.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a while ago we moved all parts of
dask_awkwardthat import upstreamawkwardinside of alibsubmodule and made the top level__init__.pyuse__getattr__to find classes and functions inlibon-demand. The purpose of this was to avoid importingawkwardunnecessarily (i.e. on a remote dask scheduler). As ofdask==2023.4.0anddistributed==2023.4.0the scheduler is now required to have the same installed packages as the client and workers [1], so this workaround is now pointless. It will make life easier (and make finding function definitions/references in IDEs easter) if we use simple top level namespace imports.[1] https://distributed.dask.org/en/stable/changelog.html#v2023-4-0