fix: try DriveDocumentQuery from DocumentQuery start field #2407
Conversation
pauldelucia
requested review from
shumkov and
QuantumExplorer
as code owners
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)packages/rs-sdk/src/platform/document_query.rs (1)
Switching ✅ Verification successfulLet me gather more information about the StartAfter implementation to better understand the context. Let me check the implementation of StartAfter handling in the query module. Based on the analysis of the codebase, I can now provide the final response:
The verification shows that
The instances of 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify no remaining references assume `start_at_included` is set to true when using StartAfter
rg -A 5 $'start_at_included.*true'
Length of output: 2682 Script: #!/bin/bash
# Search for StartAfter enum and its usage
ast-grep --pattern 'enum Start {
$$$
StartAfter($_)
$$$
}'
# Also check for any tests involving StartAfter
rg -A 5 "StartAfter"
Length of output: 40056 Script: #!/bin/bash
# Search for the implementation of Start enum and its variants
ast-grep --pattern 'enum Start {
$$$
}'
# Look for query implementations handling start_at_included
rg -A 10 'match start \{'
Length of output: 3756 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Issue being fixed or feature implemented
We were setting the
start_at_includedfield to true when it should be false in the case that the DriveQuery was using StartAfterWhat was done?
Set to false
How Has This Been Tested?
DET
Breaking Changes
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
start_at_includedfield in document queries, ensuring correct inclusivity/exclusivity when converting between query types.