-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm-dpp): add extra methods for state transitions #2401
Open
pshenmic
wants to merge
20
commits into
v1.8-dev
Choose a base branch
from
feat/wasm-extra-fields
base: v1.8-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6196555
feat(wasm-dpp): add resource vote choice
pshenmic b69bcc6
feat(wasm-dpp): implement userFeeIncrease
pshenmic 6744f4e
feat(wasm-dpp): add identity and identity contract nonces
pshenmic 699c633
feat(wasm-dpp): ensure signature and signature public key id in each …
pshenmic dc5aedb
fix(wasm-dpp): remove duplicated
pshenmic 797e75b
fix(wasm-dpp): remove duplicated
pshenmic cacc5e7
fix(wasm-dpp): add prefundedVotingBalance in create document transition
pshenmic 23c0672
feat(wasm-dpp): add prefundedVotingBalance in document transition
pshenmic 7a04862
feat(rs-dpp): add more action types in try from for DocumentTransitio…
pshenmic e3c3942
fix(wasm-dpp): fix js binding method name
pshenmic d7d184f
feat(wasm-dpp): add getData for DocumentTransition
pshenmic 5901158
Merge branch 'refs/heads/temp' into feat/wasm-extra-fields
pshenmic ec0c4d5
chore(wasm-dpp): cleanup masternode vote
pshenmic 0aaf02a
chore(wasm-dpp): cleanup masternode vote
pshenmic dbbac77
chore(wasm-dpp): remove duplicated nonce method
pshenmic 711463a
chore(wasm-dpp): fix nonce method naming in credit withdrawals
pshenmic bab0359
feat(wasm-dpp): add entropy getter for document transitions
pshenmic 701d1b5
feat(wasm-dpp): add entropy getter for documenttransition
pshenmic d77e1aa
feat(rs-dpp): add entropy getter in the rs dpp
pshenmic e21ae53
feat(dpp): move to optional
pshenmic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling for JSON conversion.
While the implementation is generally good, the unwrap calls on JSON conversion could lead to runtime panics.
Consider handling potential conversion errors:
📝 Committable suggestion