-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashmate): single node local network [WIP] #2392
base: v1.8-dev
Are you sure you want to change the base?
Changes from 5 commits
9b552ac
58589e6
a005bc3
705a3c2
6aa8791
5230090
e4fbfa7
833ff94
5d1c9b7
527e109
e344d6f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,7 +53,7 @@ export default function getBaseConfigFactory() { | |
port: 3001, | ||
}, | ||
docker: { | ||
image: 'dashpay/dashd:22', | ||
image: 'dashpay/dashd:22.1.0-devpr6437.f0e7eb57', | ||
commandArgs: [], | ||
}, | ||
p2p: { | ||
|
@@ -310,7 +310,7 @@ export default function getBaseConfigFactory() { | |
tenderdash: { | ||
mode: 'full', | ||
docker: { | ||
image: 'dashpay/tenderdash:1', | ||
image: 'dashpay/tenderdash:feat-support-quorum-111', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid using feature branch Docker image in production. Using a feature branch (
Consider using a stable, tagged release version instead. |
||
}, | ||
p2p: { | ||
host: '0.0.0.0', | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,23 +68,23 @@ export default function getLocalConfigFactory(getBaseConfig) { | |
epochTime: 1200, | ||
validatorSet: { | ||
quorum: { | ||
llmqType: 106, | ||
llmqType: 111, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Replace magic number with constant from constants.js The hardcoded value - llmqType: 111,
+ llmqType: QUORUM_TYPES.LLMQ_TYPE_1, Also applies to: 79-79, 87-87 |
||
dkgInterval: 24, | ||
activeSigners: 2, | ||
rotation: false, | ||
}, | ||
}, | ||
chainLock: { | ||
quorum: { | ||
llmqType: 100, | ||
llmqType: 111, | ||
dkgInterval: 24, | ||
activeSigners: 2, | ||
rotation: false, | ||
}, | ||
}, | ||
instantLock: { | ||
quorum: { | ||
llmqType: 104, | ||
llmqType: 111, | ||
dkgInterval: 24, | ||
activeSigners: 2, | ||
rotation: false, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ export const NODE_TYPE_FULLNODE = 'fullnode'; | |
|
||
export const LLMQ_TYPE_TEST = 'llmq_test'; | ||
export const LLMQ_TYPE_TEST_PLATFORM = 'llmq_test_platform'; | ||
export const LLMQ_TYPE_1 = 'llmq_1_100'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add mapping for LLMQ_TYPE_1 in QUORUM_TYPES object The new constant Add the mapping to maintain consistency: export const QUORUM_TYPES = {
LLMQ_TYPE_TEST: 100,
LLMQ_TYPE_TEST_PLATFORM: 106,
+ LLMQ_TYPE_1: 111,
};
|
||
|
||
export const QUORUM_TYPES = { | ||
LLMQ_TYPE_TEST: 100, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review usage of development Docker image.
Using a development PR version (
22.1.0-devpr6437.f0e7eb57
) of the Core image in base configuration could introduce instability.Consider: