-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dpp): add method for decoding identifier with unknown string encoding #2230
Conversation
WalkthroughThe changes introduce a new public method named Changes
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Issue being fixed or feature implemented
A utility function (
from_string_unknown_encoding
) was added to support decoding anIdentifier
when the encoding format (Base58, Base64, or Hex) is unknown. This function attempts to decode using all supported formats and returns an error if none match. This is useful when the input format is not guaranteed.What was done?
from_string_unknown_encoding
function to try decoding with Base58, Base64, and Hex in sequence.Identifier
struct to integrate this new utility.How Has This Been Tested?
Breaking Changes
None. This change is additive and does not alter existing functionality.
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit
Identifier
struct that allows decoding strings from multiple encoding formats (Hex, Base58, Base64).