-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dapi): optional argument start
for EpochsInfo
#2099
Conversation
@owl352 is this ready for review? |
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@QuantumExplorer used in #2105 |
Issue being fixed or feature implemented
At the momment we can't set
start
inEpochsInfo
in nodejs dapi-client, But this argument is not necessary.As result, we can't get last epoch info
What was done?
Has been added ternary for
setStartEpoch
How Has This Been Tested?
Manual testing was performed on a local testnet node, which has created via dashmate
Breaking Changes
no breaking changes
Checklist:
For repository code-owners and collaborators only