Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: replay issue when round is 0 on replay. #2091

Merged
merged 13 commits into from
Aug 30, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Aug 29, 2024

Issue being fixed or feature implemented

There were a few pretty bad issues fixed in this PR.
First there were issues when reenabling withdrawal keys.
There were also issues when dealing with complex situations around operator identity changes.
But the most important fix is that we can now rollback to the transaction savepoint properly. Without this multiple rounds at genesis would crash the system.

What was done?

Updated to GroveDB v2.0.3
Added many tests.
A lot of fixes in Masternode identity updates.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer marked this pull request as ready for review August 29, 2024 22:38
@shumkov shumkov changed the title fix: replay issue when round is 0 on replay. fix!: replay issue when round is 0 on replay. Aug 30, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuantumExplorer QuantumExplorer merged commit 20f692d into v1.2-dev Aug 30, 2024
76 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/masternodeDiffAtGenesis branch August 30, 2024 05:45
@thephez thephez added this to the v1.2.0 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants