Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): remove dash-cli from protx registration instructions #2018

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Jul 29, 2024

Issue being fixed or feature implemented

dashmate setup command for new masternodes displays an instructions to register it in the network. This is usually done from the Dash Core GUI wallet and dash-cli prefix is obsolete, as well as slashes.

What was done?

Roved dash-cli and slashes from the dashmate setup

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic self-assigned this Jul 29, 2024
@pshenmic pshenmic added this to the v1.0.0 milestone Jul 29, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pshenmic pshenmic merged commit 2f2ba10 into v1.0-dev Jul 29, 2024
22 checks passed
@pshenmic pshenmic deleted the fix/dashmate-protx-text branch July 29, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants