Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform)!: transient properties #1990

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

Properties such as the preorderSalt in DPNS are important for validation but not important after validation.

What was done?

In this PR we add transient properties to data contracts. Transient properties are a way to send data to Platform for validation without having the data stay stored in the state. These properties are discarded after validation.

The reason this was done before V1 is that doing it after might prove to be really complicated.

How Has This Been Tested?

Breaking Changes

This is a breaking change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner July 23, 2024 14:04
@QuantumExplorer QuantumExplorer merged commit 2facc4d into v1.0-dev Jul 23, 2024
71 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/transientProperties2 branch July 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants