Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dapi): can't parse masternode list diff #1988

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 23, 2024

Issue being fixed or feature implemented

Can't parse masternode list diff due to wrong serialize and deserialise logic in JS dashcore-lib

What was done?

  • Use CBOR instead as a temporary workaround

How Has This Been Tested?

With CI

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jul 23, 2024
@shumkov shumkov requested a review from QuantumExplorer as a code owner July 23, 2024 12:55
@shumkov shumkov force-pushed the fix/dapi/cant-parse-sml branch from 2c94ad5 to 21b6b95 Compare July 23, 2024 16:20
@shumkov shumkov merged commit 4d7c856 into v1.0-dev Jul 24, 2024
59 of 60 checks passed
@shumkov shumkov deleted the fix/dapi/cant-parse-sml branch July 24, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants