Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drive): added config for grovedb verify on startup #1975

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 17, 2024

Issue being fixed or feature implemented

We shouldn't verify grovedb on every start since verification could take a long time on big database

What was done?

  • Added a flag in DriveConfig which enables/disables grovedb verification on startup.
  • This flag will be disabled by default.

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jul 17, 2024
@shumkov shumkov requested a review from QuantumExplorer as a code owner July 17, 2024 12:26
Copy link
Collaborator

@ogabrielides ogabrielides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if for any reason grovedb is corrupted, the node will stall?

@shumkov
Copy link
Member Author

shumkov commented Jul 18, 2024

Correct. Drive has a separate CLI command to verify grovedb

@ogabrielides ogabrielides changed the title chore(drive): do not verify grovedb on start feat(drive): added config for grovedb verify on startup Jul 18, 2024
@fominok
Copy link
Contributor

fominok commented Jul 19, 2024

How to change this parameter in platform, isn't dashmate is supposed to be updated as well?

@shumkov
Copy link
Member Author

shumkov commented Jul 19, 2024

@fominok yeah, but I don't think we gonna change it in upcoming months. @QuantumExplorer do we? I think we can add it to dashmate later.

@shumkov shumkov merged commit cffc763 into v1.0-dev Jul 24, 2024
35 checks passed
@shumkov shumkov deleted the chore/drive/remove-verify-grovedb branch July 24, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants