Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix docker build for release #1965

Merged
merged 1 commit into from
Jul 16, 2024
Merged

ci: fix docker build for release #1965

merged 1 commit into from
Jul 16, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 16, 2024

Issue being fixed or feature implemented

https://github.com/dashpay/platform/actions/runs/9960069760

What was done?

  • Passed AWS creds to docker build

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from QuantumExplorer as a code owner July 16, 2024 16:02
@shumkov shumkov added this to the v1.0.0 milestone Jul 16, 2024
ktechmidas
ktechmidas approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@ktechmidas ktechmidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shumkov shumkov merged commit 76a6a44 into v1.0-dev Jul 16, 2024
6 of 10 checks passed
@shumkov shumkov deleted the ci/fix-release branch July 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumExplorer QuantumExplorer QuantumExplorer approved these changes

@ktechmidas ktechmidas ktechmidas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shumkov @ktechmidas @QuantumExplorer