-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashmate): verify system requirements #1914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
commented
Jun 28, 2024
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Show resolved
Hide resolved
shumkov
commented
Jun 28, 2024
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
thephez
reviewed
Jun 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shumkov I left a few suggestions. All pretty minor stuff
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
thephez
reviewed
Jul 2, 2024
packages/dashmate/src/listr/tasks/setup/regular/verifySystemRequirementsTaskFactory.js
Outdated
Show resolved
Hide resolved
…quirementsTaskFactory.js Co-authored-by: thephez <[email protected]>
…quirementsTaskFactory.js Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
pshenmic
previously approved these changes
Jul 9, 2024
…quirements # Conflicts: # packages/dashmate/src/createDIContainer.js # packages/dashmate/src/listr/tasks/setup/setupRegularPresetTaskFactory.js
thephez
added a commit
to thephez/dash-user-docs
that referenced
this pull request
Jul 16, 2024
Requirements from: dashpay/platform#1914
thephez
added a commit
to dashpay/docs
that referenced
this pull request
Jul 17, 2024
* docs: remove manual evonode setup These instructions were for Core-only evonodes which are going away with Platform's launch * docs: remove details not required when doing DMT or dashmate setup * docs: add callout about payout address * docs: add evonode requirements based on dashmate checks Requirements from: dashpay/platform#1914 * docs: minor reword * docs: update firewall info * docs: update mn/en table and description * docs: add warning and minimize core collateral storage by default * docs: minor cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
During a node setup, dashmate should verify and suggest minimal system requirements to users
What was done?
dashmate setup
command: CPU, RAM, free disk spaceHow Has This Been Tested?
Running
dashmate setup
locallyBreaking Changes
None
Checklist:
For repository code-owners and collaborators only