Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk): increase test coverage of masternode voting #1906

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Jun 25, 2024

Issue being fixed or feature implemented

Masternode Voting delivers 6 new endpoints. We need to ensure they work.

What was done?

Implemented additional tests.

TODO

  • regenerate test vectors
  • implmenet Mockable on Dapi errors
  • implement offline tests for tests that check errors

How Has This Been Tested?

cargo test -p dash-sdk --no-default-features -F network-testing  -- --include-ignored

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek and others added 30 commits June 17, 2024 12:31
…WithMasternodeVoting' into test/mn-voting-sdk
…WithMasternodeVoting' into test/mn-voting-sdk
…WithMasternodeVoting' into test/mn-voting-sdk
@lklimek lklimek marked this pull request as ready for review July 3, 2024 13:04
@lklimek lklimek force-pushed the test/mn-voting-sdk-2 branch from 61608bb to 6873ec3 Compare July 3, 2024 22:04
…WithMasternodeVoting' into test/mn-voting-sdk-2
@lklimek lklimek merged commit 4f71941 into feat/contestedDocumentResolutionWithMasternodeVoting Jul 4, 2024
2 checks passed
@lklimek lklimek deleted the test/mn-voting-sdk-2 branch July 4, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants