fix: contested document resolution fixes 2 and improvement to masternode vote #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldelucia
approved these changes
Jun 25, 2024
QuantumExplorer
changed the title
QuantumExplorer
merged commit 467bfa7
into
feat/contestedDocumentResolutionWithMasternodeVoting
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
A few queries were giving wrong results in the sdk, they should now be fixed.
Masternode vote was using the owner identity instead of the voting identity, this should now be fixed.
The verification of the masternode vote by clients should now work.
What was done?
How Has This Been Tested?
Added additional tests.
Breaking Changes
Checklist:
For repository code-owners and collaborators only