Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contested resources query fixes #1896

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

Fixes a bug where empty index values would conflict with document storage.

What was done?

Added indexes to a subtree for safety

How Has This Been Tested?

Added some tests

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner June 18, 2024 13:05
},
);

estimated_costs_only_with_layer_info.insert(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you insert estimated_costs_only_with_layer_info twice for purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, they are not the same

@QuantumExplorer QuantumExplorer merged commit a75ca37 into feat/contestedDocumentResolutionWithMasternodeVoting Jun 18, 2024
2 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/bugFixesForContestedDocumentResolutionWithMasternodeVoting branch June 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants