Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: removal of already required system fields #1886

Closed
wants to merge 2 commits into from

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 13, 2024

Issue being fixed or feature implemented

Currently, we do not support making optional already required document system fields such as $createdAt, $createdAtHeight, etc. This will break the state and ST processing logic.

What was done?

  • Do not allow to remove fields started from $ on from required list on data contract update.

How Has This Been Tested?

Added a test that expects an error on removal.

Breaking Changes

Data contract update validation rules are changed. Previous blockchain data might not be valid.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jun 13, 2024
@shumkov shumkov requested a review from QuantumExplorer as a code owner June 13, 2024 10:59
@shumkov shumkov marked this pull request as draft June 13, 2024 14:12
@shumkov shumkov closed this Jun 14, 2024
@shumkov shumkov deleted the fix/dpp/required-system-fields branch June 14, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant