Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: register init contracts on second block of strategy #1808

Merged
merged 7 commits into from
Apr 13, 2024

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Apr 8, 2024

Issue being fixed or feature implemented

Before, we could only register 24 contracts on the first block of the strategy because we only had one identity available in the TUI (the loaded identity) and 24 is the nonce limit.

What was done?

Now, we process the start_identities on the first block of the strategy, and the initial contracts on the second block. This way we can use the new identities to create more initial contracts.

How Has This Been Tested?

Platform TUI

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pauldelucia pauldelucia marked this pull request as ready for review April 9, 2024 06:36
@QuantumExplorer QuantumExplorer merged commit 60ac47d into v1.0-dev Apr 13, 2024
62 checks passed
@QuantumExplorer QuantumExplorer deleted the contracts-on-second-block-in-strategies branch April 13, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants