Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: rs-sdk tests refactoring #1566

Merged
merged 7 commits into from
Nov 7, 2023

Conversation

lklimek
Copy link
Contributor

@lklimek lklimek commented Nov 7, 2023

Issue being fixed or feature implemented

Structure of rs-sdk tests can be simplified

What was done?

  1. Use DPNS contract id, document id, identity id created on genesis instead of asking users to provide them
  2. Create rs-sdk .env file during yarn setup process
  3. Move Config code around and simplify it
  4. Reorganize test-related docs
  5. Update docs

How Has This Been Tested?

Run online testing using local network.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

packages/rs-sdk/README.md Outdated Show resolved Hide resolved
scripts/configure_dotenv.sh Show resolved Hide resolved
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@lklimek lklimek marked this pull request as ready for review November 7, 2023 09:29
@lklimek lklimek merged commit 2a7ee77 into feat/rs-drive-light-client Nov 7, 2023
1 check passed
@lklimek lklimek deleted the rs-sdk/tests-review-feedback branch November 7, 2023 09:30
lklimek added a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants