Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate): config is not persisted after migration #1561

Merged
merged 13 commits into from
Nov 5, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Nov 3, 2023

Issue being fixed or feature implemented

When dashmate migrate config to the new version, it should be persist back to disk, but it's not. So dashmate migrate config every command call without actual effect of this migration.
There are few commands that mutate config. It should be persisted in this case too.

What was done?

  • Keep status of changes for configs and config file
  • Persist config file if changed
  • Render templates for a config if it was changed

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

pshenmic
pshenmic previously approved these changes Nov 3, 2023
Copy link
Collaborator

@pshenmic pshenmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works

@shumkov shumkov merged commit 3ab754f into master Nov 5, 2023
10 checks passed
@shumkov shumkov deleted the fix/dashmate/migrated-config-is-no-persistet branch November 5, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants