fix(drive-abci): cached protocol versions #1516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orm into fix/cachedProtocolVersions
pshenmic
pushed a commit
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We were having an issue of non determinism when the round was > 0. This was because there was a version cache that wasn't being properly reset between rounds.
What was done?
Created a block cache for protocol versions that is merged into main cache on block commit.
How Has This Been Tested?
The existing strategy tests all pass. Creating a comprehensive strategy test with multiple rounds and multiple nodes should be done, but it is not a simple task, so we should merge this in asap first.
Breaking Changes
Checklist:
For repository code-owners and collaborators only