Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashmate)!: payment queue and extend enabled count #1505

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Oct 18, 2023

Issue being fixed or feature implemented

#1294

Extend status masternode command with detailed info about enabled and total nodes and fix payment queue calculation algorithm

What was done?

How Has This Been Tested?

Locally

Breaking Changes

  • Removed scope.nodeState.enabledCount in status masternode (replaced with scope.masternodeEnabled

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic self-assigned this Oct 18, 2023
@pshenmic pshenmic changed the base branch from v1.0-dev to master October 18, 2023 15:56
@pshenmic pshenmic marked this pull request as draft October 18, 2023 16:48
@shumkov shumkov changed the title feat(dashmate): fix payment queue and extend enabled count fix(dashmate): payment queue and extend enabled count Oct 23, 2023
@shumkov shumkov changed the title fix(dashmate): payment queue and extend enabled count fix(dashmate)!: payment queue and extend enabled count Oct 23, 2023
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pshenmic pshenmic marked this pull request as ready for review October 23, 2023 09:41
@pshenmic pshenmic merged commit 5b97973 into master Oct 23, 2023
10 checks passed
@pshenmic pshenmic deleted the feat/dashmate-fix-payment-queue branch October 23, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants