fix(drive-abci)!: masternode identities unique keys #1459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Masternode operator keys were being added to the unique tree lookup. If a masternode would go offline and then come back online then the key would be re-inserted as unique and the system would break.
What was done?
Masternode operator keys are no longer considered unique in the system. Also if a unique operator key was already taken by an identity it can still be used by a masternode as to prevent users from breaking Platform.
How Has This Been Tested?
Ran tests.
Breaking Changes
This is a breaking chance as masternode operator keys are no longer added to the unique tree lookup.
Checklist:
For repository code-owners and collaborators only