fix(drive-abci)!: double state transition with document same unique index #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumExplorer
changed the title
shumkov
reviewed
Oct 7, 2023
...xecution/platform_events/state_transition_processing/process_raw_state_transitions/v0/mod.rs
Outdated
Show resolved
Hide resolved
shumkov
previously approved these changes
Oct 7, 2023
…f github.com:dashpay/platform into fix/doubleStateTransitionWithDocumentSameUniqueIndex
QuantumExplorer
changed the title
|
Dashmate tests seem broken in v1.0 for now, merging as this didn't cause errors there. |
QuantumExplorer
deleted the
fix/doubleStateTransitionWithDocumentSameUniqueIndex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There was a report of a situation where two state transitions going for the same unique index would cause an error, we made some changes and wrote a test to make sure there wouldn't be an issue.
What was done?
There are a few changes in this PR. Many changes to make testing easier.
DPNS and Dashpay are now system contracts, meaning they are always loaded, and not just cached.
How Has This Been Tested?
Created a new strategy test.
Breaking Changes
I believe there will be some breaking changes because of some small differences in serialization of Null values, however I am not sure.
Checklist:
For repository code-owners and collaborators only