refactor: fees to use version system #2657
Triggered via pull request
June 30, 2024 14:39
Status
Cancelled
Total duration
2h 12m 24s
Artifacts
–
tests.yml
on: pull_request
Build JS packages
/
Build JS
0s
Matrix: Build Docker images
Determine changed packages
17s
Rust crates security audit
36s
JS dependency versions check
10s
JS NPM security audit
13s
JS code security audit
/
Run Code QL
Packages functional tests
/
Run functional tests
Matrix: Test Suite
Waiting for pending jobs
Matrix: Dashmate E2E tests
Waiting for pending jobs
Matrix: JS packages
Waiting for pending jobs
Matrix: Rust packages
Annotations
6 errors and 78 warnings
Build JS packages / Build JS
Canceling since a higher priority waiting request for 'Tests-refs/pull/1911/merge' exists
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Canceling since a higher priority waiting request for 'Tests-refs/pull/1911/merge' exists
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Canceling since a higher priority waiting request for 'Tests-refs/pull/1911/merge' exists
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Canceling since a higher priority waiting request for 'Tests-refs/pull/1911/merge' exists
|
Rust packages (drive-abci) / Tests
Canceling since a higher priority waiting request for 'Tests-refs/pull/1911/merge' exists
|
Rust packages (drive-abci) / Check each feature
Canceling since a higher priority waiting request for 'Tests-refs/pull/1911/merge' exists
|
Determine changed packages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust crates security audit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: rustsec/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust crates security audit
5 warnings found!
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
Rust packages (dash-sdk) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (dash-sdk) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (dapi-grpc) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (dapi-grpc) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (dpp) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (dpp) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (drive) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (drive) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (rs-dapi-client) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (rs-dapi-client) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (drive-abci) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (drive-abci) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (wasm-dpp) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (wasm-dpp) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (dapi-grpc) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (dapi-grpc) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (dapi-grpc) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (dash-sdk) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`:
packages/rs-drive/src/drive/document/mod.rs#L42
warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`
--> packages/rs-drive/src/drive/document/mod.rs:42:5
|
42 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`:
packages/rs-drive/src/drive/document/mod.rs#L43
warning: unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`
--> packages/rs-drive/src/drive/document/mod.rs:43:5
|
43 | use dpp::data_contract::document_type::methods::DocumentTypeV0Methods;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `dpp::data_contract::document_type::DocumentTypeRef`:
packages/rs-drive/src/drive/document/mod.rs#L45
warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef`
--> packages/rs-drive/src/drive/document/mod.rs:45:5
|
45 | use dpp::data_contract::document_type::DocumentTypeRef;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `dpp::document::DocumentV0Getters`:
packages/rs-drive/src/drive/document/mod.rs#L48
warning: unused import: `dpp::document::DocumentV0Getters`
--> packages/rs-drive/src/drive/document/mod.rs:48:5
|
48 | use dpp::document::DocumentV0Getters;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `HashSet`:
packages/rs-drive/src/drive/identity/key/fetch/mod.rs#L3
warning: unused import: `HashSet`
--> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:3:29
|
3 | collections::{BTreeMap, HashSet},
| ^^^^^^^
|
unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0`:
packages/rs-drive/src/drive/identity/key/fetch/mod.rs#L22
warning: unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0`
--> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:22:9
|
22 | identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `dpp::util::deserializer::ProtocolVersion`:
packages/rs-drive/src/fee_pools/mod.rs#L52
warning: unused import: `dpp::util::deserializer::ProtocolVersion`
--> packages/rs-drive/src/fee_pools/mod.rs:52:5
|
52 | use dpp::util::deserializer::ProtocolVersion;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `serialization_traits::DocumentPlatformConversionMethodsV0`:
packages/rs-drive/src/query/mod.rs#L24
warning: unused import: `serialization_traits::DocumentPlatformConversionMethodsV0`
--> packages/rs-drive/src/query/mod.rs:24:13
|
24 | serialization_traits::DocumentPlatformConversionMethodsV0, Document, DocumentV0Getters,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused import: `crate::drive::verify::RootHash`:
packages/rs-drive/src/query/mod.rs#L40
warning: unused import: `crate::drive::verify::RootHash`
--> packages/rs-drive/src/query/mod.rs:40:5
|
40 | use crate::drive::verify::RootHash;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unused variable: `value`:
packages/rs-drive/src/query/mod.rs#L237
warning: unused variable: `value`
--> packages/rs-drive/src/query/mod.rs:237:32
|
237 | pub fn encode_value(&self, value: &Value) -> Result<Vec<u8>, Error> {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_value`
|
= note: `#[warn(unused_variables)]` on by default
|
Rust packages (dash-sdk) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (dash-sdk) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (dpp) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-dpp/src/document/document_factory/v0/mod.rs#L215
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-dpp/src/document/document_factory/v0/mod.rs:215:24
|
215 | let documents: Vec<(
| ________________________^
216 | | DocumentTransitionActionType,
217 | | Vec<(Document, DocumentTypeRef, Bytes32)>,
218 | | )> = documents_iter.into_iter().collect();
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs#L223
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs:223:24
|
223 | let documents: Vec<(
| ________________________^
224 | | DocumentTransitionActionType,
225 | | Vec<(Document, DocumentTypeRef, Bytes32)>,
226 | | )> = documents_iter.into_iter().collect();
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
module has the same name as its containing module:
packages/rs-dpp/src/identity/mod.rs#L10
warning: module has the same name as its containing module
--> packages/rs-dpp/src/identity/mod.rs:10:1
|
10 | mod identity;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
large size difference between variants:
packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs#L28
warning: large size difference between variants
--> packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs:28:1
|
28 | / pub enum AssetLockProof {
29 | | Instant(#[bincode(with_serde)] InstantAssetLockProof),
| | ----------------------------------------------------- the largest variant contains at least 640 bytes
30 | | Chain(#[bincode(with_serde)] ChainAssetLockProof),
| | ------------------------------------------------- the second-largest variant contains at least 40 bytes
31 | | }
| |_^ the entire enum is at least 640 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
29 | Instant(#[bincode(with_serde)] Box<InstantAssetLockProof>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
|
module has the same name as its containing module:
packages/rs-dpp/src/util/cbor_value/mod.rs#L11
warning: module has the same name as its containing module
--> packages/rs-dpp/src/util/cbor_value/mod.rs:11:1
|
11 | mod cbor_value;
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
module has the same name as its containing module:
packages/rs-dpp/src/errors/consensus/basic/json_schema_error/mod.rs#L1
warning: module has the same name as its containing module
--> packages/rs-dpp/src/errors/consensus/basic/json_schema_error/mod.rs:1:1
|
1 | pub mod json_schema_error;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
you should consider adding a `Default` implementation for `JsonSchemaValidator`:
packages/rs-dpp/src/validation/json_schema_validator/methods/new/mod.rs#L10
warning: you should consider adding a `Default` implementation for `JsonSchemaValidator`
--> packages/rs-dpp/src/validation/json_schema_validator/methods/new/mod.rs:10:5
|
10 | / pub fn new() -> Self {
11 | | Self {
12 | | validator: RwLock::new(None),
13 | | }
14 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
9 + impl Default for JsonSchemaValidator {
10 + fn default() -> Self {
11 + Self::new()
12 + }
13 + }
|
|
module has the same name as its containing module:
packages/rs-dpp/src/tests/utils/mod.rs#L2
warning: module has the same name as its containing module
--> packages/rs-dpp/src/tests/utils/mod.rs:2:1
|
2 | mod utils;
| ^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
Rust packages (drive) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
unused import: `crate::consensus::basic::BasicError`:
packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs#L1
warning: unused import: `crate::consensus::basic::BasicError`
--> packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs:1:5
|
1 | use crate::consensus::basic::BasicError;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
unused import: `crate::consensus::ConsensusError`:
packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs#L2
warning: unused import: `crate::consensus::ConsensusError`
--> packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs:2:5
|
2 | use crate::consensus::ConsensusError;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs#L44
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs:44:10
|
44 | ) -> (
| __________^
45 | | BTreeMap<String, Vec<(KeyID, Purpose)>>,
46 | | Vec<(KeyID, Purpose)>,
47 | | ) {
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs#L174
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs:174:10
|
174 | ) -> Result<(RootHash, BTreeMap<[u8; 32], Option<DataContract>>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/verify/system/verify_elements/v0/mod.rs#L34
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/verify/system/verify_elements/v0/mod.rs:34:10
|
34 | ) -> Result<(RootHash, BTreeMap<Vec<u8>, Option<Element>>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/drive/verify/system/verify_elements/mod.rs#L37
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/drive/verify/system/verify_elements/mod.rs:37:10
|
37 | ) -> Result<(RootHash, BTreeMap<Vec<u8>, Option<Element>>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
very complex type used. Consider factoring parts into `type` definitions:
packages/rs-drive/src/query/conditions.rs#L467
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-drive/src/query/conditions.rs:467:10
|
467 | ) -> Result<(BTreeMap<String, Self>, Option<Self>, Option<Self>), Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
Rust packages (rs-dapi-client) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (drive-abci) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
unreachable pattern:
packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs#L284
warning: unreachable pattern
--> packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs:284:9
|
284 | _ => Err(Error::Execution(ExecutionError::CorruptedCodeExecution(
| ^
|
= note: `#[warn(unreachable_patterns)]` on by default
|
module has the same name as its containing module:
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L11
warning: module has the same name as its containing module
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:11:1
|
11 | mod update_masternode_identities;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs#L40
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs:40:32
|
40 | raw_state_transitions: &Vec<Vec<u8>>,
| ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs#L251
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs:251:17
|
251 | &signable_bytes_hasher.hash_bytes().as_slice(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs#L178
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs:178:17
|
178 | &signable_bytes_hasher.hash_bytes().as_slice(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
`to_string` applied to a type that implements `Display` in `format!` args:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L494
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:494:223
|
494 | ... new block)", self.current_validator_set_quorum_hash.to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash...
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
useless conversion to the same type: `indexmap::map::Keys<'_, dpp::dashcore::QuorumHash, platform_types::validator_set::ValidatorSet>`:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L494
warning: useless conversion to the same type: `indexmap::map::Keys<'_, dpp::dashcore::QuorumHash, platform_types::validator_set::ValidatorSet>`
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:494:237
|
494 | ...to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash.to_string()).join(" | "),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.validator_sets.keys()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `#[warn(clippy::useless_conversion)]` on by default
|
Rust packages (dpp) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (rs-dapi-client) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (rs-dapi-client) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (wasm-dpp) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
module has the same name as its containing module:
packages/wasm-dpp/src/data_contract_factory/mod.rs#L1
warning: module has the same name as its containing module
--> packages/wasm-dpp/src/data_contract_factory/mod.rs:1:1
|
1 | mod data_contract_factory;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
packages/wasm-dpp/src/document/factory.rs#L153
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/wasm-dpp/src/document/factory.rs:153:24
|
153 | let documents: Vec<(
| ________________________^
154 | | DocumentTransitionActionType,
155 | | Vec<(Document, DocumentTypeRef, Bytes32)>,
156 | | )> = documents_by_action
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
use of a fallible conversion when an infallible one could be used:
packages/wasm-dpp/src/document/factory.rs#L322
warning: use of a fallible conversion when an infallible one could be used
--> packages/wasm-dpp/src/document/factory.rs:322:27
|
322 | let documents_array = js_sys::Array::try_from(documents_with_action)
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `From::from`
|
= note: converting `JsValue` to `Array` cannot fail
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
= note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
|
you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm`:
packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs#L21
warning: you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm`
--> packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs:21:5
|
21 | / pub fn new() -> Self {
22 | | Self {
23 | | inner: MissingStateTransitionTypeError::new(),
24 | | }
25 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
19 + impl Default for MissingStateTransitionTypeErrorWasm {
20 + fn default() -> Self {
21 + Self::new()
22 + }
23 + }
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs#L34
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs:34:9
|
34 | *self.inner.setting_identity_contract_nonce() as u64
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*self.inner.setting_identity_contract_nonce()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm`:
packages/wasm-dpp/src/errors/value_error.rs#L29
warning: implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm`
--> packages/wasm-dpp/src/errors/value_error.rs:29:5
|
29 | / pub fn to_string(&self) -> String {
30 | | format!("PlatformValueError: {}", self.message)
31 | | }
| |_____^
|
= help: implement trait `Display` for type `errors::value_error::PlatformValueErrorWasm` instead
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string
= note: `#[warn(clippy::inherent_to_string)]` on by default
|
module has the same name as its containing module:
packages/wasm-dpp/src/identity/mod.rs#L30
warning: module has the same name as its containing module
--> packages/wasm-dpp/src/identity/mod.rs:30:1
|
30 | mod identity;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
module has the same name as its containing module:
packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs#L4
warning: module has the same name as its containing module
--> packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs:4:1
|
4 | pub mod identity_create_transition;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
called `unwrap` on `document_type_name` after checking its variant with `is_some`:
packages/wasm-dpp/src/identity/state_transition/identity_public_key_transitions.rs#L117
warning: called `unwrap` on `document_type_name` after checking its variant with `is_some`
--> packages/wasm-dpp/src/identity/state_transition/identity_public_key_transitions.rs:117:37
|
114 | let contract_bounds = if document_type_name.is_some() {
| ------------------------------- help: try: `if let Some(..) = document_type_name`
...
117 | document_type_name: document_type_name.unwrap(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
= note: `#[warn(clippy::unnecessary_unwrap)]` on by default
|
module has the same name as its containing module:
packages/wasm-dpp/src/identity/state_transition/identity_topup_transition/mod.rs#L4
warning: module has the same name as its containing module
--> packages/wasm-dpp/src/identity/state_transition/identity_topup_transition/mod.rs:4:1
|
4 | pub mod identity_topup_transition;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
Rust packages (dpp) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (wasm-dpp) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (drive) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|