perf(drive)!: verify instant lock signatures with Drive #2588
Annotations
11 warnings
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
packages/rs-dpp/src/data_contract/errors/contract.rs#L6
warning: unused import: `platform_value::Identifier`
--> packages/rs-dpp/src/data_contract/errors/contract.rs:6:5
|
6 | use platform_value::Identifier;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L2
warning: unused import: `IdentityPublicKey`
--> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:2:23
|
2 | use crate::identity::{IdentityPublicKey, IdentityV0, KeyType, Purpose, SecurityLevel};
| ^^^^^^^^^^^^^^^^^
|
packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L7
warning: unused import: `std::collections::BTreeMap`
--> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:7:5
|
7 | use std::collections::BTreeMap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
packages/rs-dpp/src/document/document_factory/v0/mod.rs#L215
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-dpp/src/document/document_factory/v0/mod.rs:215:24
|
215 | let documents: Vec<(
| ________________________^
216 | | DocumentTransitionActionType,
217 | | Vec<(Document, DocumentTypeRef, Bytes32)>,
218 | | )> = documents_iter.into_iter().collect();
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs#L223
warning: very complex type used. Consider factoring parts into `type` definitions
--> packages/rs-dpp/src/document/specialized_document_factory/v0/mod.rs:223:24
|
223 | let documents: Vec<(
| ________________________^
224 | | DocumentTransitionActionType,
225 | | Vec<(Document, DocumentTypeRef, Bytes32)>,
226 | | )> = documents_iter.into_iter().collect();
| |__________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
|
packages/rs-dpp/src/identity/mod.rs#L10
warning: module has the same name as its containing module
--> packages/rs-dpp/src/identity/mod.rs:10:1
|
10 | mod identity;
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs#L28
warning: large size difference between variants
--> packages/rs-dpp/src/identity/state_transition/asset_lock_proof/mod.rs:28:1
|
28 | / pub enum AssetLockProof {
29 | | Instant(#[bincode(with_serde)] InstantAssetLockProof),
| | ----------------------------------------------------- the largest variant contains at least 640 bytes
30 | | Chain(#[bincode(with_serde)] ChainAssetLockProof),
| | ------------------------------------------------- the second-largest variant contains at least 40 bytes
31 | | }
| |_^ the entire enum is at least 640 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
29 | Instant(#[bincode(with_serde)] Box<InstantAssetLockProof>),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
|
packages/rs-dpp/src/util/cbor_value/mod.rs#L11
warning: module has the same name as its containing module
--> packages/rs-dpp/src/util/cbor_value/mod.rs:11:1
|
11 | mod cbor_value;
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
packages/rs-dpp/src/errors/consensus/basic/json_schema_error/mod.rs#L1
warning: module has the same name as its containing module
--> packages/rs-dpp/src/errors/consensus/basic/json_schema_error/mod.rs:1:1
|
1 | pub mod json_schema_error;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
|
packages/rs-dpp/src/validation/json_schema_validator/methods/new/mod.rs#L10
warning: you should consider adding a `Default` implementation for `JsonSchemaValidator`
--> packages/rs-dpp/src/validation/json_schema_validator/methods/new/mod.rs:10:5
|
10 | / pub fn new() -> Self {
11 | | Self {
12 | | validator: RwLock::new(None),
13 | | }
14 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
9 + impl Default for JsonSchemaValidator {
10 + fn default() -> Self {
11 + Self::new()
12 + }
13 + }
|
|
This job succeeded
Loading