Skip to content

chore: revisit system data contracts #2535

chore: revisit system data contracts

chore: revisit system data contracts #2535

Triggered via pull request June 14, 2024 13:13
Status Failure
Total duration 3h 27m 19s
Artifacts

tests.yml

on: pull_request
Build JS packages  /  Build JS
3m 14s
Build JS packages / Build JS
Matrix: Build Docker images
Determine changed packages
16s
Determine changed packages
Rust crates security audit
31s
Rust crates security audit
JS dependency versions check
11s
JS dependency versions check
JS NPM security audit
15s
JS NPM security audit
JS code security audit  /  Run Code QL
3m 33s
JS code security audit / Run Code QL
Packages functional tests  /  Run functional tests
Packages functional tests / Run functional tests
Matrix: Test Suite
Waiting for pending jobs
Matrix: Dashmate E2E tests
Waiting for pending jobs
Matrix: JS packages
Matrix: Rust packages
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 141 warnings
Rust packages (drive) / Tests
Process completed with exit code 101.
Rust packages (dpp) / Linting
The self-hosted runner: ubuntu-platform-arm64_i-04fb2dd723e9c39ff lost communication with the server. Verify the machine is running and has a healthy network connection. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.
Rust packages (drive-abci) / Tests
Process completed with exit code 101.
Build Docker images (Drive, drive, drive-abci) / Build Drive image
buildx failed with: ERROR: failed to solve: Canceled: failed to check file presence in cache: operation error S3: HeadObject, context canceled
Determine changed packages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust crates security audit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: rustsec/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust crates security audit
5 warnings found!
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
Rust packages (drive) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (dash-sdk) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dash-sdk) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (dpns-contract) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dpns-contract) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (drive-abci) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive-abci) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (dashpay-contract) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dashpay-contract) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dash-sdk) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dpns-contract) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dash-sdk) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6
warning: unused import: `platform_value::Identifier` --> packages/rs-dpp/src/data_contract/errors/contract.rs:6:5 | 6 | use platform_value::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters`: packages/rs-drive/src/drive/document/mod.rs#L42
warning: unused import: `dpp::data_contract::document_type::accessors::DocumentTypeV0Getters` --> packages/rs-drive/src/drive/document/mod.rs:42:5 | 42 | use dpp::data_contract::document_type::accessors::DocumentTypeV0Getters; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods`: packages/rs-drive/src/drive/document/mod.rs#L43
warning: unused import: `dpp::data_contract::document_type::methods::DocumentTypeV0Methods` --> packages/rs-drive/src/drive/document/mod.rs:43:5 | 43 | use dpp::data_contract::document_type::methods::DocumentTypeV0Methods; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `dpp::data_contract::document_type::DocumentTypeRef`: packages/rs-drive/src/drive/document/mod.rs#L45
warning: unused import: `dpp::data_contract::document_type::DocumentTypeRef` --> packages/rs-drive/src/drive/document/mod.rs:45:5 | 45 | use dpp::data_contract::document_type::DocumentTypeRef; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `dpp::document::DocumentV0Getters`: packages/rs-drive/src/drive/document/mod.rs#L48
warning: unused import: `dpp::document::DocumentV0Getters` --> packages/rs-drive/src/drive/document/mod.rs:48:5 | 48 | use dpp::document::DocumentV0Getters; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `HashSet`: packages/rs-drive/src/drive/identity/key/fetch/mod.rs#L3
warning: unused import: `HashSet` --> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:3:29 | 3 | collections::{BTreeMap, HashSet}, | ^^^^^^^
unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0`: packages/rs-drive/src/drive/identity/key/fetch/mod.rs#L22
warning: unused import: `identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0` --> packages/rs-drive/src/drive/identity/key/fetch/mod.rs:22:9 | 22 | identity::identity_public_key::accessors::v0::IdentityPublicKeyGettersV0, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `dpp::util::deserializer::ProtocolVersion`: packages/rs-drive/src/fee_pools/mod.rs#L52
warning: unused import: `dpp::util::deserializer::ProtocolVersion` --> packages/rs-drive/src/fee_pools/mod.rs:52:5 | 52 | use dpp::util::deserializer::ProtocolVersion; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `serialization_traits::DocumentPlatformConversionMethodsV0`: packages/rs-drive/src/query/mod.rs#L24
warning: unused import: `serialization_traits::DocumentPlatformConversionMethodsV0` --> packages/rs-drive/src/query/mod.rs:24:13 | 24 | serialization_traits::DocumentPlatformConversionMethodsV0, Document, DocumentV0Getters, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::drive::verify::RootHash`: packages/rs-drive/src/query/mod.rs#L40
warning: unused import: `crate::drive::verify::RootHash` --> packages/rs-drive/src/query/mod.rs:40:5 | 40 | use crate::drive::verify::RootHash; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Rust packages (dpns-contract) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dash-sdk) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6
warning: unused import: `platform_value::Identifier` --> packages/rs-dpp/src/data_contract/errors/contract.rs:6:5 | 6 | use platform_value::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `crate::consensus::basic::BasicError`: packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs#L1
warning: unused import: `crate::consensus::basic::BasicError` --> packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs:1:5 | 1 | use crate::consensus::basic::BasicError; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::consensus::ConsensusError`: packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs#L2
warning: unused import: `crate::consensus::ConsensusError` --> packages/rs-dpp/src/data_contract/document_type/class_methods/mod.rs:2:5 | 2 | use crate::consensus::ConsensusError; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `IdentityPublicKey`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L2
warning: unused import: `IdentityPublicKey` --> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:2:23 | 2 | use crate::identity::{IdentityPublicKey, IdentityV0, KeyType, Purpose, SecurityLevel}; | ^^^^^^^^^^^^^^^^^
unused import: `std::collections::BTreeMap`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L7
warning: unused import: `std::collections::BTreeMap` --> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:7:5 | 7 | use std::collections::BTreeMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^^
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs#L44
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/identity/contract_info/keys/mod.rs:44:10 | 44 | ) -> ( | __________^ 45 | | BTreeMap<String, Vec<(KeyID, Purpose)>>, 46 | | Vec<(KeyID, Purpose)>, 47 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs#L174
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/verify/contract/verify_contract/v0/mod.rs:174:10 | 174 | ) -> Result<(RootHash, BTreeMap<[u8; 32], Option<DataContract>>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/verify/system/verify_elements/v0/mod.rs#L34
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/verify/system/verify_elements/v0/mod.rs:34:10 | 34 | ) -> Result<(RootHash, BTreeMap<Vec<u8>, Option<Element>>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/drive/verify/system/verify_elements/mod.rs#L37
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/drive/verify/system/verify_elements/mod.rs:37:10 | 37 | ) -> Result<(RootHash, BTreeMap<Vec<u8>, Option<Element>>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
very complex type used. Consider factoring parts into `type` definitions: packages/rs-drive/src/query/conditions.rs#L467
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/rs-drive/src/query/conditions.rs:467:10 | 467 | ) -> Result<(BTreeMap<String, Self>, Option<Self>, Option<Self>), Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
Rust packages (dashpay-contract) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dashpay-contract) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (dpp) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive-abci) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6
warning: unused import: `platform_value::Identifier` --> packages/rs-dpp/src/data_contract/errors/contract.rs:6:5 | 6 | use platform_value::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `IdentityPublicKey`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L2
warning: unused import: `IdentityPublicKey` --> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:2:23 | 2 | use crate::identity::{IdentityPublicKey, IdentityV0, KeyType, Purpose, SecurityLevel}; | ^^^^^^^^^^^^^^^^^
unused import: `std::collections::BTreeMap`: packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L7
warning: unused import: `std::collections::BTreeMap` --> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:7:5 | 7 | use std::collections::BTreeMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^^
unused import: `crate::execution::validation::state_transition::documents_batch::data_triggers::triggers::feature_flags::create_feature_flag_data_trigger`: packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/bindings/list/v0/mod.rs#L3
warning: unused import: `crate::execution::validation::state_transition::documents_batch::data_triggers::triggers::feature_flags::create_feature_flag_data_trigger` --> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/bindings/list/v0/mod.rs:3:5 | 3 | use crate::execution::validation::state_transition::documents_batch::data_triggers::triggers::feature_flags::create_feature_flag_data_trigg... | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
unused import: `dpp::system_data_contracts::feature_flags_contract::v1::document_types::update_consensus_params`: packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/bindings/list/v0/mod.rs#L9
warning: unused import: `dpp::system_data_contracts::feature_flags_contract::v1::document_types::update_consensus_params` --> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/bindings/list/v0/mod.rs:9:5 | 9 | use dpp::system_data_contracts::feature_flags_contract::v1::document_types::update_consensus_params; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
unreachable pattern: packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs#L284
warning: unreachable pattern --> packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs:284:9 | 284 | _ => Err(Error::Execution(ExecutionError::CorruptedCodeExecution( | ^ | = note: `#[warn(unreachable_patterns)]` on by default
unused variable: `platform_version`: packages/rs-drive-abci/src/platform_types/signature_verification_quorums/mod.rs#L22
warning: unused variable: `platform_version` --> packages/rs-drive-abci/src/platform_types/signature_verification_quorums/mod.rs:22:41 | 22 | pub fn default_for_platform_version(platform_version: &PlatformVersion) -> Self { | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_platform_version` | = note: `#[warn(unused_variables)]` on by default
function `create_feature_flag_data_trigger` is never used: packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/triggers/feature_flags/mod.rs#L10
warning: function `create_feature_flag_data_trigger` is never used --> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/triggers/feature_flags/mod.rs:10:8 | 10 | pub fn create_feature_flag_data_trigger( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
function `create_feature_flag_data_trigger_v0` is never used: packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/triggers/feature_flags/v0/mod.rs#L35
warning: function `create_feature_flag_data_trigger_v0` is never used --> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/documents_batch/data_triggers/triggers/feature_flags/v0/mod.rs:35:15 | 35 | pub(super) fn create_feature_flag_data_trigger_v0( | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
module has the same name as its containing module: packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L11
warning: module has the same name as its containing module --> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:11:1 | 11 | mod update_masternode_identities; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
Rust packages (dpp) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dpp) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (dpp) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (wasm-dpp) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (wasm-dpp) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rust packages (wasm-dpp) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
unused import: `platform_value::Identifier`: packages/rs-dpp/src/data_contract/errors/contract.rs#L6
warning: unused import: `platform_value::Identifier` --> packages/rs-dpp/src/data_contract/errors/contract.rs:6:5 | 6 | use platform_value::Identifier; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
module has the same name as its containing module: packages/wasm-dpp/src/data_contract_factory/mod.rs#L1
warning: module has the same name as its containing module --> packages/wasm-dpp/src/data_contract_factory/mod.rs:1:1 | 1 | mod data_contract_factory; | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default
very complex type used. Consider factoring parts into `type` definitions: packages/wasm-dpp/src/document/factory.rs#L153
warning: very complex type used. Consider factoring parts into `type` definitions --> packages/wasm-dpp/src/document/factory.rs:153:24 | 153 | let documents: Vec<( | ________________________^ 154 | | DocumentTransitionActionType, 155 | | Vec<(Document, DocumentTypeRef, Bytes32)>, 156 | | )> = documents_by_action | |__________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
use of a fallible conversion when an infallible one could be used: packages/wasm-dpp/src/document/factory.rs#L322
warning: use of a fallible conversion when an infallible one could be used --> packages/wasm-dpp/src/document/factory.rs:322:27 | 322 | let documents_array = js_sys::Array::try_from(documents_with_action) | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `From::from` | = note: converting `JsValue` to `Array` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm`: packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs#L21
warning: you should consider adding a `Default` implementation for `MissingStateTransitionTypeErrorWasm` --> packages/wasm-dpp/src/errors/consensus/basic/state_transition/missing_state_transition_type_error.rs:21:5 | 21 | / pub fn new() -> Self { 22 | | Self { 23 | | inner: MissingStateTransitionTypeError::new(), 24 | | } 25 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 19 + impl Default for MissingStateTransitionTypeErrorWasm { 20 + fn default() -> Self { 21 + Self::new() 22 + } 23 + } |
casting to the same type is unnecessary (`u64` -> `u64`): packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs#L34
warning: casting to the same type is unnecessary (`u64` -> `u64`) --> packages/wasm-dpp/src/errors/consensus/state/identity/invalid_identity_contract_nonce_error.rs:34:9 | 34 | *self.inner.setting_identity_contract_nonce() as u64 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*self.inner.setting_identity_contract_nonce()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm`: packages/wasm-dpp/src/errors/value_error.rs#L29
warning: implementation of inherent method `to_string(&self) -> String` for type `errors::value_error::PlatformValueErrorWasm` --> packages/wasm-dpp/src/errors/value_error.rs:29:5 | 29 | / pub fn to_string(&self) -> String { 30 | | format!("PlatformValueError: {}", self.message) 31 | | } | |_____^ | = help: implement trait `Display` for type `errors::value_error::PlatformValueErrorWasm` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string = note: `#[warn(clippy::inherent_to_string)]` on by default
module has the same name as its containing module: packages/wasm-dpp/src/identity/mod.rs#L30
warning: module has the same name as its containing module --> packages/wasm-dpp/src/identity/mod.rs:30:1 | 30 | mod identity; | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
module has the same name as its containing module: packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs#L4
warning: module has the same name as its containing module --> packages/wasm-dpp/src/identity/state_transition/identity_create_transition/mod.rs:4:1 | 4 | pub mod identity_create_transition; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
called `unwrap` on `document_type_name` after checking its variant with `is_some`: packages/wasm-dpp/src/identity/state_transition/identity_public_key_transitions.rs#L117
warning: called `unwrap` on `document_type_name` after checking its variant with `is_some` --> packages/wasm-dpp/src/identity/state_transition/identity_public_key_transitions.rs:117:37 | 114 | let contract_bounds = if document_type_name.is_some() { | ------------------------------- help: try: `if let Some(..) = document_type_name` ... 117 | document_type_name: document_type_name.unwrap(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
Rust packages (wasm-dpp) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive) / Tests
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.316.1. Please update to the latest version 2.317.0
Rust packages (drive) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build JS packages / Build JS
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, mozilla-actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive-abci) / Tests
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.316.1. Please update to the latest version 2.317.0
Rust packages (drive-abci) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Rust packages (drive-abci) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/platform-test-suite) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dashpay-contract) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dpns-contract) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/wallet-lib) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dash) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Client.ts#L10
Dependency cycle via ./Platform:1
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Client.ts#L166
Assignment to function parameter 'options'
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Fetcher/Fetcher.ts#L143
Returning an awaited value that is not a promise is not allowed
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.spec.ts#L5
Using exported name 'Client' as identifier for default export
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L5
Using exported name 'Client' as identifier for default export
JS packages (dash) / Linting: packages/js-dash-sdk/src/SDK/Client/Platform/Platform.ts#L8
Using exported name 'createAssetLockTransaction' as identifier for default export
JS packages (@dashevo/wasm-dpp) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi-client) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dashmate) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dashpay-contract) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dashmate) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dpns-contract) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
JS packages (@dashevo/wasm-dpp) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi-client) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
Build Docker images (Drive, drive, drive-abci) / Build Drive image
This job failure may be caused by using an out of date self-hosted runner. You are currently using runner version 2.316.1. Please update to the latest version 2.317.0
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/dapi) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (@dashevo/wallet-lib) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS packages (dash) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS code security audit / Run Code QL
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
JS code security audit / Run Code QL
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/