refactor(drive): encapsulate chain lock validation quorum logic #2523
tests.yml
on: pull_request
Build JS packages
/
Build JS
2m 51s
Matrix: Build Docker images
Determine changed packages
17s
Rust crates security audit
32s
JS dependency versions check
13s
JS NPM security audit
15s
JS code security audit
/
Run Code QL
2m 10s
Packages functional tests
/
Run functional tests
3m 30s
Matrix: Test Suite
Matrix: Dashmate E2E tests
Waiting for pending jobs
Matrix: JS packages
Waiting for pending jobs
Matrix: Rust packages
Annotations
2 errors and 36 warnings
Tests
Error when evaluating 'strategy' for job 'js-packages'. .github/workflows/tests.yml (Line: 115, Col: 21): Matrix vector 'js-package' does not contain any values
|
Tests
Error when evaluating 'strategy' for job 'js-packages'. .github/workflows/tests.yml (Line: 115, Col: 21): Matrix vector 'js-package' does not contain any values
|
Rust crates security audit
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: rustsec/audit-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust crates security audit
5 warnings found!
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
Determine changed packages
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, dorny/paths-filter@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust crates security audit
Unknown warning kind unsound found, please, file a bug
|
Build JS packages / Build JS
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, mozilla-actions/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (DAPI, dapi, dapi) / Build DAPI image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Input 'config-inline' has been deprecated with message: Use buildkitd-config-inline instead
|
Build Docker images (Drive, drive, drive-abci) / Build Drive image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/github-script@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (drive-abci) / Unused dependencies
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (drive-abci) / Unused dependencies
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust packages (drive-abci) / Check each feature
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust packages (drive-abci) / Linting
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
unused import: `platform_value::Identifier`:
packages/rs-dpp/src/data_contract/errors/contract.rs#L6
warning: unused import: `platform_value::Identifier`
--> packages/rs-dpp/src/data_contract/errors/contract.rs:6:5
|
6 | use platform_value::Identifier;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
unused import: `IdentityPublicKey`:
packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L2
warning: unused import: `IdentityPublicKey`
--> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:2:23
|
2 | use crate::identity::{IdentityPublicKey, IdentityV0, KeyType, Purpose, SecurityLevel};
| ^^^^^^^^^^^^^^^^^
|
unused import: `std::collections::BTreeMap`:
packages/rs-dpp/src/tests/fixtures/identity_fixture.rs#L7
warning: unused import: `std::collections::BTreeMap`
--> packages/rs-dpp/src/tests/fixtures/identity_fixture.rs:7:5
|
7 | use std::collections::BTreeMap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
unreachable pattern:
packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs#L284
warning: unreachable pattern
--> packages/rs-drive-abci/src/execution/validation/state_transition/check_tx_verification/v0/mod.rs:284:9
|
284 | _ => Err(Error::Execution(ExecutionError::CorruptedCodeExecution(
| ^
|
= note: `#[warn(unreachable_patterns)]` on by default
|
unused variable: `platform_version`:
packages/rs-drive-abci/src/platform_types/signature_verification_quorums/mod.rs#L20
warning: unused variable: `platform_version`
--> packages/rs-drive-abci/src/platform_types/signature_verification_quorums/mod.rs:20:41
|
20 | pub fn default_for_platform_version(platform_version: &PlatformVersion) -> Self {
| ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_platform_version`
|
= note: `#[warn(unused_variables)]` on by default
|
module has the same name as its containing module:
packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs#L11
warning: module has the same name as its containing module
--> packages/rs-drive-abci/src/execution/platform_events/core_based_updates/update_masternode_identities/mod.rs:11:1
|
11 | mod update_masternode_identities;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
= note: `#[warn(clippy::module_inception)]` on by default
|
writing `&Vec` instead of `&[_]` involves a new object where a slice will do:
packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs#L40
warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
--> packages/rs-drive-abci/src/execution/platform_events/state_transition_processing/process_raw_state_transitions/mod.rs:40:32
|
40 | raw_state_transitions: &Vec<Vec<u8>>,
| ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs#L251
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_create/state/v0/mod.rs:251:17
|
251 | &signable_bytes_hasher.hash_bytes().as_slice(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs#L178
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> packages/rs-drive-abci/src/execution/validation/state_transition/state_transitions/identity_top_up/transform_into_action/v0/mod.rs:178:17
|
178 | &signable_bytes_hasher.hash_bytes().as_slice(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signable_bytes_hasher.hash_bytes().as_slice()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
`to_string` applied to a type that implements `Display` in `format!` args:
packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs#L462
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> packages/rs-drive-abci/src/platform_types/platform_state/v0/mod.rs:462:223
|
462 | ... new block)", self.current_validator_set_quorum_hash.to_string(), self.validator_sets.keys().into_iter().map(|quorum_hash| quorum_hash...
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
Rust packages (drive-abci) / Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
JS code security audit / Run Code QL
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, github/codeql-action/init@v2, github/codeql-action/analyze@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
JS code security audit / Run Code QL
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
|
Packages functional tests / Run functional tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test Suite (Test Suite in browser (2), test:browsers, 1, 2) / Run Test Suite in browser (2)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test Suite (Test Suite, test:suite, 0, 0) / Run Test Suite
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Test Suite (Test Suite in browser (1), test:browsers, 0, 2) / Run Test Suite in browser (1)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: strophy/actions-cache@opendal-update, strophy/actions-cache/restore@opendal-update. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|