refactor(drive): remove duplicated withdrawal amount validation #3978
Annotations
12 warnings
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: mozilla-actions/[email protected], strophy/actions-cache@opendal-update. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
packages/rs-platform-serialization-derive/src/attribute.rs#L8
warning: field `unversioned` is never read
--> packages/rs-platform-serialization-derive/src/attribute.rs:8:9
|
5 | pub struct ContainerAttributes {
| ------------------- field in this struct
...
8 | pub unversioned: bool,
| ^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
packages/rs-platform-serialization-derive/src/attribute.rs#L114
warning: field `platform_version_path_bounds` is never read
--> packages/rs-platform-serialization-derive/src/attribute.rs:114:9
|
111 | pub struct FieldAttributes {
| --------------- field in this struct
...
114 | pub platform_version_path_bounds: String,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
packages/rs-dpp/src/state_transition/mod.rs#L155
warning: unused variable: `st`
--> packages/rs-dpp/src/state_transition/mod.rs:155:45
|
155 | StateTransition::IdentityCreate(st) => None,
| ^^ help: if this is intentional, prefix it with an underscore: `_st`
...
404 | call_getter_method_identity_signed!(self, security_level_requirement, purpose)
| ------------------------------------------------------------------------------ in this macro invocation
|
= note: `#[warn(unused_variables)]` on by default
= note: this warning originates in the macro `call_getter_method_identity_signed` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
packages/rs-dpp/src/state_transition/mod.rs#L156
warning: unused variable: `st`
--> packages/rs-dpp/src/state_transition/mod.rs:156:44
|
156 | StateTransition::IdentityTopUp(st) => None,
| ^^ help: if this is intentional, prefix it with an underscore: `_st`
...
404 | call_getter_method_identity_signed!(self, security_level_requirement, purpose)
| ------------------------------------------------------------------------------ in this macro invocation
|
= note: this warning originates in the macro `call_getter_method_identity_signed` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L1203
warning: taken reference of right operand
--> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1203:20
|
1203 | if value == &vec![0] {
| ^^^^^^^^^--------
| |
| help: use the right value directly: `...`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
= note: `#[warn(clippy::op_ref)]` on by default
|
|
packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L1294
warning: taken reference of right operand
--> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1294:20
|
1294 | if value == &vec![0] {
| ^^^^^^^^^--------
| |
| help: use the right value directly: `...`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
|
|
packages/rs-dpp/src/data_contract/document_type/property/mod.rs#L1296
warning: taken reference of right operand
--> packages/rs-dpp/src/data_contract/document_type/property/mod.rs:1296:27
|
1296 | } else if value == &vec![1] {
| ^^^^^^^^^--------
| |
| help: use the right value directly: `...`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
|
|
packages/rs-dpp/src/data_contract/document_type/index/mod.rs#L157
warning: non-canonical implementation of `partial_cmp` on an `Ord` type
--> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:157:1
|
157 | / impl PartialOrd for ContestedIndexFieldMatch {
158 | | fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
| | _____________________________________________________________-
159 | || use ContestedIndexFieldMatch::*;
160 | || match (self, other) {
161 | || // Comparing two integers
... ||
170 | || }
171 | || }
| ||_____- help: change this to: `{ Some(self.cmp(other)) }`
172 | | }
| |__^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
= note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
|
|
packages/rs-dpp/src/data_contract/document_type/index/mod.rs#L503
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> packages/rs-dpp/src/data_contract/document_type/index/mod.rs:503:66
|
503 | ... e.to_string()
| ^^^^^^^^^^^^ help: remove this
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
packages/rs-dpp/src/data_contract/document_type/v0/random_document_type.rs#L396
warning: iterating on a map's values
--> packages/rs-dpp/src/data_contract/document_type/v0/random_document_type.rs:396:35
|
396 | let indices_json_schema = indices
| ___________________________________^
397 | | .iter()
398 | | .map(|(_, index)| {
399 | | let properties_schema = index
... |
412 | | })
413 | | })
| |______________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map
= note: `#[warn(clippy::iter_kv_map)]` on by default
help: try
|
396 ~ let indices_json_schema = indices.values().map(|index| {
397 + let properties_schema = index
398 + .properties
399 + .iter()
400 + .map(|prop| {
401 + // Only "asc" is allowed for now (v1.0-dev)
402 + json!({ <std::string::String as Clone>::clone(&prop.name): "asc" })
403 + })
404 + .collect::<Vec<_>>();
405 +
406 + json!({
407 + "name": index.name,
408 + "properties": properties_schema,
409 + "unique": index.unique,
410 + })
411 + })
|
|
This job succeeded
Loading