Skip to content

fix: just in time update #403

fix: just in time update

fix: just in time update #403

This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Actions / clippy failed Sep 27, 2023 in 0s

clippy

3 errors, 6 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 6
Note 0
Help 0

Versions

  • rustc 1.72.1 (d5c2e9c34 2023-09-13)
  • cargo 1.72.1 (103a7ff2e 2023-08-15)
  • clippy 0.1.72 (d5c2e9c 2023-09-13)

Annotations

Check failure on line 982 in grovedb/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this method takes 3 arguments but 2 arguments were supplied

error[E0061]: this method takes 3 arguments but 2 arguments were supplied
   --> grovedb/src/lib.rs:982:22
    |
982 |                     .get_value_and_value_hash(&key, true)
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^------------ an argument of type `std::option::Option<_>` is missing
    |
note: method defined here
   --> /home/runner/work/grovedb/grovedb/merk/src/merk/get.rs:165:12
    |
165 |     pub fn get_value_and_value_hash(
    |            ^^^^^^^^^^^^^^^^^^^^^^^^
help: provide the argument
    |
982 |                     .get_value_and_value_hash(&key, true, /* value_defined_cost_fn */)
    |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 951 in grovedb/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this method takes 3 arguments but 2 arguments were supplied

error[E0061]: this method takes 3 arguments but 2 arguments were supplied
   --> grovedb/src/lib.rs:951:22
    |
951 |                     .get_value_and_value_hash(&key, true)
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^------------ an argument of type `std::option::Option<_>` is missing
    |
note: method defined here
   --> /home/runner/work/grovedb/grovedb/merk/src/merk/get.rs:165:12
    |
165 |     pub fn get_value_and_value_hash(
    |            ^^^^^^^^^^^^^^^^^^^^^^^^
help: provide the argument
    |
951 |                     .get_value_and_value_hash(&key, true, /* value_defined_cost_fn */)
    |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 915 in grovedb/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this method takes 3 arguments but 2 arguments were supplied

error[E0061]: this method takes 3 arguments but 2 arguments were supplied
   --> grovedb/src/lib.rs:915:22
    |
915 |                     .get_value_and_value_hash(&key, true)
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^------------ an argument of type `std::option::Option<_>` is missing
    |
note: method defined here
   --> /home/runner/work/grovedb/grovedb/merk/src/merk/get.rs:165:12
    |
165 |     pub fn get_value_and_value_hash(
    |            ^^^^^^^^^^^^^^^^^^^^^^^^
help: provide the argument
    |
915 |                     .get_value_and_value_hash(&key, true, /* value_defined_cost_fn */)
    |                                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 834 in merk/src/tree/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> merk/src/tree/mod.rs:811:5
    |
811 | /     pub fn put_value_with_reference_value_hash_and_value_cost(
812 | |         mut self,
813 | |         value: Vec<u8>,
814 | |         value_hash: CryptoHash,
...   |
833 | |         >,
834 | |     ) -> CostResult<Self, Error> {
    | |________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 367 in merk/src/tree/walk/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> merk/src/tree/walk/mod.rs:344:5
    |
344 | /     pub fn put_value_with_reference_value_hash_and_value_cost(
345 | |         mut self,
346 | |         value: Vec<u8>,
347 | |         value_hash: CryptoHash,
...   |
366 | |         >,
367 | |     ) -> CostResult<Self, Error> {
    | |________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 638 in merk/src/tree/ops.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (9/7)

warning: this function has too many arguments (9/7)
   --> merk/src/tree/ops.rs:628:5
    |
628 | /     fn recurse<K: AsRef<[u8]>, C, V, U, R>(
629 | |         self,
630 | |         batch: &MerkBatch<K>,
631 | |         mid: usize,
...   |
637 | |         section_removal_bytes: &mut R,
638 | |     ) -> CostResult<(Option<Self>, KeyUpdates), Error>
    | |______________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 286 in merk/src/merk/apply.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> merk/src/merk/apply.rs:277:5
    |
277 | /     pub fn apply_unchecked<KB, KA, C, V, U, R>(
278 | |         &mut self,
279 | |         batch: &MerkBatch<KB>,
280 | |         aux: &AuxMerkBatch<KA>,
...   |
285 | |         section_removal_bytes: &mut R,
286 | |     ) -> CostResult<(), Error>
    | |______________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 199 in merk/src/merk/apply.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
   --> merk/src/merk/apply.rs:176:5
    |
176 | /     pub fn apply_with_costs_just_in_time_value_update<KB, KA>(
177 | |         &mut self,
178 | |         batch: &MerkBatch<KB>,
179 | |         aux: &AuxMerkBatch<KA>,
...   |
198 | |         >,
199 | |     ) -> CostResult<(), Error>
    | |______________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
    = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 430 in storage/src/rocksdb_storage/storage.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `std::result::Result` that must be used

warning: unused `std::result::Result` that must be used
   --> storage/src/rocksdb_storage/storage.rs:430:13
    |
430 |             self.db.delete(iter.key().expect("should have key"));
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this `Result` may be an `Err` variant, which should be handled
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
430 |             let _ = self.db.delete(iter.key().expect("should have key"));
    |             +++++++