-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: just in time flags fix and epoch based storage flags #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantumExplorer
changed the title
fix!: just in time flags fix.
feat!: just in time flags fix and epoch based storage flags
Aug 24, 2024
shumkov
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand what I'm approving
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
A few issues existed in GroveDB.
These were mainly due to how storage flags would change with just in time upgrades.
We were originally experiencing a quadratic rise in the reporting of storage costs, even though these did not actually increase.
There was also a problem with how we merged storage costs and how we removed them.
What was done?
Storage Flags was moved into GroveDB and heavily modified.
The just in time logic was heavily modified.
Fixed issue where references would break for change of size of sum items.
Updated to v1.1.0
How Has This Been Tested?
Added a lot of tests.
Breaking Changes
This is a breaking change.
Checklist:
For repository code-owners and collaborators only