Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: just in time flags fix and epoch based storage flags #334

Merged
merged 15 commits into from
Aug 24, 2024

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Aug 23, 2024

Issue being fixed or feature implemented

A few issues existed in GroveDB.
These were mainly due to how storage flags would change with just in time upgrades.
We were originally experiencing a quadratic rise in the reporting of storage costs, even though these did not actually increase.
There was also a problem with how we merged storage costs and how we removed them.

What was done?

Storage Flags was moved into GroveDB and heavily modified.
The just in time logic was heavily modified.
Fixed issue where references would break for change of size of sum items.
Updated to v1.1.0

How Has This Been Tested?

Added a lot of tests.

Breaking Changes

This is a breaking change.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer changed the title fix!: just in time flags fix. feat!: just in time flags fix and epoch based storage flags Aug 24, 2024
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand what I'm approving

@QuantumExplorer QuantumExplorer merged commit 3684f15 into develop Aug 24, 2024
7 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/JITfix branch August 24, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants