fix!: empty parent paths should only error if we want them to error #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
If a tree on an intermediate path on a subquery path was not present we would receive an error. Now instead we have a field to allow this situation or not. If the option is set to false (don't error), then we simply don't error, any query for any item in that path will simply give back a None value.
Also we fixed an issue with terminal paths.
What was done?
How Has This Been Tested?
Added a test to verify this works as intended.
Breaking Changes
Breaking in the sense that method calls have changed.
Checklist:
For repository code-owners and collaborators only