Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improving merk deletion #271

Merged
merged 3 commits into from
Sep 28, 2023
Merged

fix: improving merk deletion #271

merged 3 commits into from
Sep 28, 2023

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

What was done?

Merk deletion is highly recursive, in this PR we remove some recursion and clean up some stack values.

How Has This Been Tested?

Ran tests, and also ran against drive.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit eade3e0 into develop Sep 28, 2023
7 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/improvingMerkDeletion branch September 28, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iammadab iammadab iammadab approved these changes

@fominok fominok Awaiting requested review from fominok fominok is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuantumExplorer @iammadab