fix: just in time update #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
There was an issue with just in time updating, this should fix those issues.
Another issue discovered was that the costs of an intermediate node update in merk was not using the layered calculation causing us to say that we were replacing an incorrect amount of bytes.
What was done?
We now have a callback for costs from merk to grovedb for value defined costs. This allows grovedb to have fine tuned control over merk costs.
How Has This Been Tested?
Breaking Changes
This is a breaking change that will affect Drive.
Checklist:
For repository code-owners and collaborators only