warning: this function has too many arguments (8/7) --> grovedb/src/lib.rs:730:5 | 730 | / fn verify_merk_and_submerks_in_transaction<'db, B: AsRef<[u8]>, S: StorageContext<'db>>( 731 | | &'db self, 732 | | merk: Merk<S>, 733 | | path: &SubtreePath, ... | 738 | | grove_version: &GroveVersion, 739 | | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | |___________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

very complex type used. Consider factoring parts into `type` definitions: grovedb/src/lib.rs#L739

warning: very complex type used. Consider factoring parts into `type` definitions --> grovedb/src/lib.rs:739:10 | 739 | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: grovedb/src/lib.rs#L715

warning: very complex type used. Consider factoring parts into `type` definitions --> grovedb/src/lib.rs:715:10 | 715 | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

the following explicit lifetimes could be elided: 'db: grovedb/src/replication.rs#L49

warning: the following explicit lifetimes could be elided: 'db --> grovedb/src/replication.rs:49:6 | 49 | impl<'db> Default for MultiStateSyncInfo<'db> { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 49 - impl<'db> Default for MultiStateSyncInfo<'db> { 49 + impl Default for MultiStateSyncInfo<'_> { |

the following explicit lifetimes could be elided: 'a: grovedb/src/query/mod.rs#L512

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/query/mod.rs:512:6 | 512 | impl<'a> fmt::Display for SinglePathSubquery<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 512 - impl<'a> fmt::Display for SinglePathSubquery<'a> { 512 + impl fmt::Display for SinglePathSubquery<'_> { |

the following explicit lifetimes could be elided: 'a: grovedb/src/query/mod.rs#L483

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/query/mod.rs:483:6 | 483 | impl<'a> HasSubquery<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 483 - impl<'a> HasSubquery<'a> { 483 + impl HasSubquery<'_> { |

the following explicit lifetimes could be elided: 'a: grovedb/src/query/mod.rs#L467

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/query/mod.rs:467:6 | 467 | impl<'a> fmt::Display for HasSubquery<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 467 - impl<'a> fmt::Display for HasSubquery<'a> { 467 + impl fmt::Display for HasSubquery<'_> { |

called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`: grovedb/src/operations/proof/verify.rs#L366

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/verify.rs:366:25 | 366 | limit_left.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = limit_left.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn

called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`: grovedb/src/operations/proof/verify.rs#L292

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/verify.rs:292:17 | 292 | limit_left.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = limit_left.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn = note: `#[warn(clippy::option_map_unit_fn)]` on by default

this function has too many arguments (8/7): grovedb/src/operations/proof/verify.rs#L228

this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/operations/proof/generate.rs#L216

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/operations/proof/generate.rs:216:74 | 216 | self.open_transactional_merk_at_path(path.as_slice().into(), &tx, None, grove_version) | ^^^ help: change this to: `tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this function has too many arguments (8/7): grovedb/src/operations/insert/mod.rs#L104

warning: this function has too many arguments (8/7) --> grovedb/src/operations/insert/mod.rs:104:5 | 104 | / fn add_element_on_transaction<'db, 'b, 'c, B: AsRef<[u8]>>( 105 | | &'db self, 106 | | path: SubtreePath<'b, B>, 107 | | key: &[u8], ... | 114 | | grove_version: &GroveVersion, 115 | | ) -> CostResult<MerkHandle<'db, 'c>, Error> { | |_______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/operations/get/query.rs#L545

warning: this function has too many arguments (8/7) --> grovedb/src/operations/get/query.rs:545:5 | 545 | / pub fn query_raw( 546 | | &self, 547 | | path_query: &PathQuery, 548 | | allow_cache: bool, ... | 553 | | grove_version: &GroveVersion, 554 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/operations/get/query.rs#L230

warning: this function has too many arguments (8/7) --> grovedb/src/operations/get/query.rs:230:5 | 230 | / pub fn query( 231 | | &self, 232 | | path_query: &PathQuery, 233 | | allow_cache: bool, ... | 238 | | grove_version: &GroveVersion, 239 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/operations/get/query.rs#L113

this function has too many arguments (8/7): grovedb/src/operations/delete/mod.rs#L579

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/mod.rs:579:5 | 579 | / fn delete_internal<B: AsRef<[u8]>>( 580 | | &self, 581 | | path: SubtreePath, 582 | | key: &[u8], ... | 594 | | grove_version: &GroveVersion, 595 | | ) -> CostResult<bool, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/operations/delete/mod.rs#L446

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/mod.rs:446:5 | 446 | / pub fn delete_operation_for_delete_internal<B: AsRef<[u8]>>( 447 | | &self, 448 | | path: SubtreePath, 449 | | key: &[u8], ... | 454 | | grove_version: &GroveVersion, 455 | | ) -> CostResult<Option<QualifiedGroveDbOp>, Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/operations/delete/worst_case.rs#L119

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/worst_case.rs:119:5 | 119 | / pub fn worst_case_delete_operation_for_delete<'db, S: Storage<'db>>( 120 | | path: &KeyInfoPath, 121 | | key: &KeyInfo, 122 | | parent_tree_is_sum_tree: bool, ... | 127 | | grove_version: &GroveVersion, 128 | | ) -> CostResult<QualifiedGroveDbOp, Error> { | |______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/operations/delete/delete_up_tree.rs#L197

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/delete_up_tree.rs:197:5 | 197 | / pub fn add_delete_operations_for_delete_up_tree_while_empty<B: AsRef<[u8]>>( 198 | | &self, 199 | | path: SubtreePath, 200 | | key: &[u8], ... | 205 | | grove_version: &GroveVersion, 206 | | ) -> CostResult<Option<Vec<QualifiedGroveDbOp>>, Error> { | |___________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/operations/delete/delete_up_tree.rs#L165

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/delete_up_tree.rs:165:5 | 165 | / pub fn delete_operations_for_delete_up_tree_while_empty<B: AsRef<[u8]>>( 166 | | &self, 167 | | path: SubtreePath, 168 | | key: &[u8], ... | 173 | | grove_version: &GroveVersion, 174 | | ) -> CostResult<Vec<QualifiedGroveDbOp>, Error> { | |___________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/operations/delete/average_case.rs#L139

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/average_case.rs:139:5 | 139 | / pub fn average_case_delete_operation_for_delete<'db, S: Storage<'db>>( 140 | | path: &KeyInfoPath, 141 | | key: &KeyInfo, 142 | | parent_tree_is_sum_tree: bool, ... | 147 | | grove_version: &GroveVersion, 148 | | ) -> CostResult<QualifiedGroveDbOp, Error> { | |______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (12/7): grovedb/src/element/query.rs#L712

warning: this function has too many arguments (12/7) --> grovedb/src/element/query.rs:712:5 | 712 | / fn query_item( 713 | | storage: &RocksDbStorage, 714 | | item: &QueryItem, 715 | | results: &mut Vec<QueryResultElement>, ... | 724 | | grove_version: &GroveVersion, 725 | | ) -> CostResult<(), Error> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/element/query.rs#L302

warning: this function has too many arguments (8/7) --> grovedb/src/element/query.rs:302:5 | 302 | / pub fn get_query_apply_function( 303 | | storage: &RocksDbStorage, 304 | | path: &[&[u8]], 305 | | sized_query: &SizedQuery, ... | 310 | | grove_version: &GroveVersion, 311 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

the following explicit lifetimes could be elided: 'a: grovedb/src/element/query.rs#L172

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/element/query.rs:172:17 | 172 | impl<'db, 'ctx, 'a> fmt::Display for PathQueryPushArgs<'db, 'ctx, 'a> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 172 - impl<'db, 'ctx, 'a> fmt::Display for PathQueryPushArgs<'db, 'ctx, 'a> 172 + impl<'db, 'ctx> fmt::Display for PathQueryPushArgs<'db, 'ctx, '_> |

this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/element/insert.rs#L514

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/element/insert.rs:514:32 | 514 | Self::get_optional(&merk, &key, true, grove_version) | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/element/insert.rs#L360

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/element/insert.rs:360:32 | 360 | Self::get_optional(&merk, &key, true, grove_version) | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/element/insert.rs#L223

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/element/insert.rs:223:32 | 223 | Self::get_optional(&merk, key, true, grove_version) | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this `let...else` may be rewritten with the `?` operator: grovedb/src/element/helpers.rs#L328

warning: this `let...else` may be rewritten with the `?` operator --> grovedb/src/element/helpers.rs:328:9 | 328 | / let Some(value_cost) = self.get_specialized_cost(grove_version).ok() else { 329 | | return None; 330 | | }; | |__________^ help: replace it with: `let value_cost = self.get_specialized_cost(grove_version).ok()?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `#[warn(clippy::question_mark)]` on by default

writing `&Vec` instead of `&[_]` involves a new object where a slice will do: grovedb/src/element/helpers.rs#L253

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> grovedb/src/element/helpers.rs:253:14 | 253 | key: &Vec<u8>, | ^^^^^^^^ help: change this to: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/debugger.rs#L335

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/debugger.rs:335:29 | 335 | ... &tx, | ^^^ help: change this to: `tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this function has too many arguments (8/7): grovedb/src/batch/mod.rs#L2335

warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:2335:5 | 2335 | / pub fn apply_partial_batch_with_element_flags_update( 2336 | | &self, 2337 | | ops: Vec<QualifiedGroveDbOp>, 2338 | | batch_apply_options: Option<BatchApplyOptions>, ... | 2357 | | grove_version: &GroveVersion, 2358 | | ) -> CostResult<(), Error> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): grovedb/src/batch/mod.rs#L1973

warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:1973:5 | 1973 | / fn continue_partial_apply_body<'db, S: StorageContext<'db>>( 1974 | | &self, 1975 | | previous_leftover_operations: Option<OpsByLevelPath>, 1976 | | additional_ops: Vec<QualifiedGroveDbOp>, ... | 1992 | | grove_version: &GroveVersion, 1993 | | ) -> CostResult<Option<OpsByLevelPath>, Error> { | |__________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

useless conversion to the same type: `batch::GroveOp`: grovedb/src/batch/mod.rs#L1899

warning: useless conversion to the same type: `batch::GroveOp` --> grovedb/src/batch/mod.rs:1899:37 | 1899 | / ... GroveOp::ReplaceTreeRootKey { 1900 | | ... hash: root_hash, 1901 | | ... root_key: calculated_root_key, 1902 | | ... sum: sum_value, 1903 | | ... } 1904 | | ... .into(), | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 1899 ~ GroveOp::ReplaceTreeRootKey { 1900 + hash: root_hash, 1901 + root_key: calculated_root_key, 1902 + sum: sum_value, 1903 ~ }, |

useless conversion to the same type: `batch::GroveOp`: grovedb/src/batch/mod.rs#L1847

warning: useless conversion to the same type: `batch::GroveOp` --> grovedb/src/batch/mod.rs:1847:61 | 1847 | / ... GroveOp::InsertTreeWithRootHash { 1848 | | ... hash: root_hash, 1849 | | ... root_key: calculated_root_key, 1850 | | ... flags: flags.clone(), 1851 | | ... sum: sum_value, 1852 | | ... } 1853 | | ... .into(); | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 1847 ~ GroveOp::InsertTreeWithRootHash { 1848 + hash: root_hash, 1849 + root_key: calculated_root_key, 1850 + flags: flags.clone(), 1851 + sum: sum_value, 1852 ~ }; |

useless conversion to the same type: `batch::GroveOp`: grovedb/src/batch/mod.rs#L1836

warning: useless conversion to the same type: `batch::GroveOp` --> grovedb/src/batch/mod.rs:1836:61 | 1836 | / ... GroveOp::InsertTreeWithRootHash { 1837 | | ... hash: root_hash, 1838 | | ... root_key: calculated_root_key, 1839 | | ... flags: flags.clone(), 1840 | | ... sum: None, 1841 | | ... } 1842 | | ... .into(); | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 1836 ~ GroveOp::InsertTreeWithRootHash { 1837 + hash: root_hash, 1838 + root_key: calculated_root_key, 1839 + flags: flags.clone(), 1840 + sum: None, 1841 ~ }; |

useless conversion to the same type: `batch::GroveOp`: grovedb/src/batch/mod.rs#L1804

warning: useless conversion to the same type: `batch::GroveOp` --> grovedb/src/batch/mod.rs:1804:49 | 1804 | / ... GroveOp::ReplaceTreeRootKey { 1805 | | ... hash: root_hash, 1806 | | ... root_key: calculated_root_key, 1807 | | ... sum: sum_value, 1808 | | ... } 1809 | | ... .into(), | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default help: consider removing `.into()` | 1804 ~ GroveOp::ReplaceTreeRootKey { 1805 + hash: root_hash, 1806 + root_key: calculated_root_key, 1807 + sum: sum_value, 1808 ~ }, |

this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/batch/mod.rs#L1542

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/batch/mod.rs:1542:29 | 1542 | ... &merk, | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

returning the result of a `let` binding from a block: grovedb/src/batch/mod.rs#L1695

warning: returning the result of a `let` binding from a block --> grovedb/src/batch/mod.rs:1695:9 | 1690 | / let r = merk 1691 | | .root_hash_key_and_sum() 1692 | | .add_cost(cost) 1693 | | .map_err(Error::MerkError); | |_______________________________________- unnecessary `let` binding 1694 | 1695 | r | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 1690 ~ 1691 | 1692 ~ merk 1693 + .root_hash_key_and_sum() 1694 + .add_cost(cost) 1695 + .map_err(Error::MerkError) |

this function has too many arguments (9/7): grovedb/src/batch/mod.rs#L969

the following explicit lifetimes could be elided: 'a: grovedb/src/batch/mod.rs#L879

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/batch/mod.rs:879:47 | 879 | fn get_and_deserialize_referenced_element<'a>( | ^^ 880 | &'a mut self, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 879 ~ fn get_and_deserialize_referenced_element( 880 ~ &mut self, |

this function has too many arguments (8/7): grovedb/src/batch/mod.rs#L751

warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:751:5 | 751 | / fn process_reference<'a, G, SR>( 752 | | &'a mut self, 753 | | qualified_path: &[Vec<u8>], 754 | | ops_by_qualified_paths: &'a BTreeMap<Vec<Vec<u8>>, GroveOp>, ... | 759 | | grove_version: &GroveVersion, 760 | | ) -> CostResult<CryptoHash, Error> | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

doc list item without indentation: grovedb/src/batch/mod.rs#L738

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:738:9 | 738 | /// missing reference, corrupted data, or invalid batch operation. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 738 | /// missing reference, corrupted data, or invalid batch operation. | ++

doc list item without indentation: grovedb/src/batch/mod.rs#L734

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:734:9 | 734 | /// associated cost, if successful. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 734 | /// associated cost, if successful. | ++

doc list item without indentation: grovedb/src/batch/mod.rs#L721

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:721:9 | 721 | /// element. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 721 | /// element. | +++

doc list item without indentation: grovedb/src/batch/mod.rs#L720

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:720:9 | 720 | /// element and then determines the next step based on the type of the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 720 | /// element and then determines the next step based on the type of the | +++

doc list item without indentation: grovedb/src/batch/mod.rs#L717

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:717:9 | 717 | /// value hash from the reference element. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 717 | /// value hash from the reference element. | +++

this function has too many arguments (8/7): grovedb/src/batch/mod.rs#L687

this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/batch/just_in_time_reference_update.rs#L62

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/batch/just_in_time_reference_update.rs:62:47 | 62 | let val_hash = value_hash(&serialized).unwrap_add_cost(&mut cost); | ^^^^^^^^^^^ help: change this to: `serialized` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

this function has too many arguments (9/7): grovedb/src/batch/just_in_time_reference_update.rs#L28

warning: this function has too many arguments (9/7) --> grovedb/src/batch/just_in_time_reference_update.rs:28:5 | 28 | / pub(crate) fn process_old_element_flags<G, SR>( 29 | | key: &[u8], 30 | | serialized: &[u8], 31 | | new_element: &mut Element, ... | 37 | | grove_version: &GroveVersion, 38 | | ) -> CostResult<CryptoHash, Error> | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

usage of `contains_key` followed by `insert` on a `HashMap`: grovedb/src/batch/estimated_costs/average_case_costs.rs#L273

warning: usage of `contains_key` followed by `insert` on a `HashMap` --> grovedb/src/batch/estimated_costs/average_case_costs.rs:273:13 | 273 | / if !self.cached_merks.contains_key(&base_path) { 274 | | cost_return_on_error_no_add!( 275 | | cost, 276 | | GroveDb::add_average_case_get_merk_at_path::<RocksDbStorage>( ... | 287 | | .insert(base_path, estimated_layer_info.is_sum_tree); 288 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 273 ~ if let std::collections::hash_map::Entry::Vacant(e) = self.cached_merks.entry(base_path) { 274 + cost_return_on_error_no_add!( 275 + cost, 276 + GroveDb::add_average_case_get_merk_at_path::<RocksDbStorage>( 277 + &mut cost, 278 + &base_path, 279 + estimated_layer_info 280 + .estimated_layer_count 281 + .estimated_to_be_empty(), 282 + estimated_layer_info.is_sum_tree, 283 + grove_version 284 + ) 285 + ); 286 + e.insert(estimated_layer_info.is_sum_tree); 287 + } |

unnecessary use of `get(path).is_none()`: grovedb/src/batch/estimated_costs/average_case_costs.rs#L219

warning: unnecessary use of `get(path).is_none()` --> grovedb/src/batch/estimated_costs/average_case_costs.rs:219:30 | 219 | if self.cached_merks.get(path).is_none() { | ------------------^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!self.cached_merks.contains_key(path)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default

function `follow_reference_once` is never used: grovedb/src/util.rs#L209

warning: function `follow_reference_once` is never used --> grovedb/src/util.rs:209:15 | 209 | pub(crate) fn follow_reference_once<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^

function `follow_reference` is never used: grovedb/src/util.rs#L125

warning: function `follow_reference` is never used --> grovedb/src/util.rs:125:15 | 125 | pub(crate) fn follow_reference<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^

struct `ResolvedReference` is never constructed: grovedb/src/util.rs#L117

warning: struct `ResolvedReference` is never constructed --> grovedb/src/util.rs:117:19 | 117 | pub(crate) struct ResolvedReference<'db, 'b, 'c, B> { | ^^^^^^^^^^^^^^^^^

method `invert` is never used: grovedb/src/reference_path.rs#L66

warning: method `invert` is never used --> grovedb/src/reference_path.rs:66:19 | 64 | impl ReferencePathType { | ---------------------- method in this implementation 65 | /// Get an inverted reference 66 | pub(crate) fn invert<B: AsRef<[u8]>>(&self, path: SubtreePath, key: &[u8]) -> Option<Self> { | ^^^^^^

variants `Execute`, `AverageCase`, and `WorstCase` are never constructed: grovedb/src/batch/mode.rs#L18

warning: variants `Execute`, `AverageCase`, and `WorstCase` are never constructed --> grovedb/src/batch/mode.rs:18:5 | 17 | pub enum BatchRunMode { | ------------ variants in this enum 18 | Execute, | ^^^^^^^ 19 | #[cfg(feature = "estimated_costs")] 20 | AverageCase(HashMap<KeyInfoPath, EstimatedLayerInformation>), | ^^^^^^^^^^^ 21 | #[cfg(feature = "estimated_costs")] 22 | WorstCase(HashMap<KeyInfoPath, WorstCaseLayerInformation>), | ^^^^^^^^^ | = note: `BatchRunMode` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis

method `get_batch_run_mode` is never used: grovedb/src/batch/mod.rs#L684

warning: method `get_batch_run_mode` is never used --> grovedb/src/batch/mod.rs:684:8 | 681 | trait TreeCache<G, SR> { | --------- method in this trait ... 684 | fn get_batch_run_mode(&self) -> BatchRunMode; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

elided lifetime has a name: grovedb/src/replication.rs#L572

warning: elided lifetime has a name --> grovedb/src/replication.rs:572:32 | 566 | fn discover_subtrees<'db>( | --- lifetime `'db` declared here ... 572 | ) -> Result<(Vec<Vec<u8>>, MultiStateSyncInfo), Error> { | ^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'db`

elided lifetime has a name: grovedb/src/replication.rs#L510

warning: elided lifetime has a name --> grovedb/src/replication.rs:510:32 | 504 | fn apply_inner_chunk<'db>( | --- lifetime `'db` declared here ... 510 | ) -> Result<(Vec<Vec<u8>>, SubtreeStateSyncInfo), Error> { | ^^^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'db`

elided lifetime has a name: grovedb/src/replication.rs#L393

warning: elided lifetime has a name --> grovedb/src/replication.rs:393:32 | 385 | pub fn apply_chunk<'db>( | --- lifetime `'db` declared here ... 393 | ) -> Result<(Vec<Vec<u8>>, MultiStateSyncInfo), Error> { | ^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'db`

elided lifetime has a name: grovedb/src/replication.rs#L325

warning: elided lifetime has a name --> grovedb/src/replication.rs:325:17 | 318 | pub fn start_snapshot_syncing<'db>( | --- lifetime `'db` declared here ... 325 | ) -> Result<MultiStateSyncInfo, Error> { | ^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'db` | = note: `#[warn(elided_named_lifetimes)]` on by default

unused import: `error::GroveVersionError`: grovedb/src/replication.rs#L17

warning: unused import: `error::GroveVersionError` --> grovedb/src/replication.rs:17:41 | 17 | use grovedb_version::{check_grovedb_v0, error::GroveVersionError, version::GroveVersion}; | ^^^^^^^^^^^^^^^^^^^^^^^^

unused import: `error::GroveVersionError`: grovedb/src/operations/delete/average_case.rs#L15

warning: unused import: `error::GroveVersionError` --> grovedb/src/operations/delete/average_case.rs:15:33 | 15 | check_grovedb_v0_with_cost, error::GroveVersionError, version::GroveVersion, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

the following explicit lifetimes could be elided: 'a: merk/src/visualize.rs#L87

warning: the following explicit lifetimes could be elided: 'a --> merk/src/visualize.rs:87:6 | 87 | impl<'a, T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize for VisualizableTree<'a, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 87 - impl<'a, T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize for VisualizableTree<'a, F> { 87 + impl<T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize for VisualizableTree<'_, F> { |

the following explicit lifetimes could be elided: 'a: merk/src/visualize.rs#L68

warning: the following explicit lifetimes could be elided: 'a --> merk/src/visualize.rs:68:6 | 68 | impl<'a, 'db, S: StorageContext<'db>, T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize | ^^ 69 | for VisualizeableMerk<'a, S, F> | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 68 ~ impl<'db, S: StorageContext<'db>, T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize 69 ~ for VisualizeableMerk<'_, S, F> |

casting to the same type is unnecessary (`u32` -> `u32`): merk/src/estimated_costs/average_case_costs.rs#L423

warning: casting to the same type is unnecessary (`u32` -> `u32`) --> merk/src/estimated_costs/average_case_costs.rs:423:24 | 423 | cost.seek_count += nodes_updated as u32; | ^^^^^^^^^^^^^^^^^^^^ help: try: `nodes_updated` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

duplicated attribute: merk/src/estimated_costs/average_case_costs.rs#L49

warning: duplicated attribute --> merk/src/estimated_costs/average_case_costs.rs:49:7 | 49 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ | note: first defined here --> merk/src/estimated_costs/average_case_costs.rs:48:7 | 48 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ help: remove this attribute --> merk/src/estimated_costs/average_case_costs.rs:49:7 | 49 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes = note: `#[warn(clippy::duplicated_attributes)]` on by default

this function has too many arguments (9/7): merk/src/tree/mod.rs#L850

warning: this function has too many arguments (9/7) --> merk/src/tree/mod.rs:850:5 | 850 | / pub fn put_value_with_reference_value_hash_and_value_cost( 851 | | mut self, 852 | | value: Vec<u8>, 853 | | value_hash: CryptoHash, ... | 876 | | >, 877 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): merk/src/tree/mod.rs#L792

warning: this function has too many arguments (8/7) --> merk/src/tree/mod.rs:792:5 | 792 | / pub fn put_value_and_reference_value_hash( 793 | | mut self, 794 | | value: Vec<u8>, 795 | | value_hash: CryptoHash, ... | 817 | | >, 818 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): merk/src/tree/mod.rs#L736

warning: this function has too many arguments (8/7) --> merk/src/tree/mod.rs:736:5 | 736 | / pub fn put_value_with_fixed_cost( 737 | | mut self, 738 | | value: Vec<u8>, 739 | | value_fixed_cost: u32, ... | 761 | | >, 762 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (9/7): merk/src/tree/walk/mod.rs#L341

warning: this function has too many arguments (9/7) --> merk/src/tree/walk/mod.rs:341:5 | 341 | / pub fn put_value_with_reference_value_hash_and_value_cost( 342 | | mut self, 343 | | value: Vec<u8>, 344 | | value_hash: CryptoHash, ... | 367 | | >, 368 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): merk/src/tree/walk/mod.rs#L295

warning: this function has too many arguments (8/7) --> merk/src/tree/walk/mod.rs:295:5 | 295 | / pub fn put_value_and_reference_value_hash( 296 | | mut self, 297 | | value: Vec<u8>, 298 | | value_hash: CryptoHash, ... | 320 | | >, 321 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): merk/src/tree/walk/mod.rs#L249

warning: this function has too many arguments (8/7) --> merk/src/tree/walk/mod.rs:249:5 | 249 | / pub fn put_value_with_fixed_cost( 250 | | mut self, 251 | | value: Vec<u8>, 252 | | value_fixed_cost: u32, ... | 274 | | >, 275 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (11/7): merk/src/tree/ops.rs#L733

this function has too many arguments (8/7): merk/src/tree/ops.rs#L415

warning: this function has too many arguments (8/7) --> merk/src/tree/ops.rs:415:5 | 415 | / fn apply_sorted<K: AsRef<[u8]>, C, V, T, U, R>( 416 | | self, 417 | | batch: &MerkBatch<K>, 418 | | old_specialized_cost: &C, ... | 423 | | grove_version: &GroveVersion, 424 | | ) -> CostResult<(Option<Self>, KeyUpdates), Error> | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): merk/src/tree/ops.rs#L235

this function has too many arguments (9/7): merk/src/tree/ops.rs#L148

warning: this function has too many arguments (9/7) --> merk/src/tree/ops.rs:148:5 | 148 | / pub fn apply_to<K: AsRef<[u8]>, C, V, T, U, R>( 149 | | maybe_tree: Option<Self>, 150 | | batch: &MerkBatch<K>, 151 | | source: S, ... | 157 | | grove_version: &GroveVersion, 158 | | ) -> CostContext<Result<(Option<TreeNode>, KeyUpdates), Error>> | |___________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

the following explicit lifetimes could be elided: 'a: merk/src/tree/iter.rs#L68

warning: the following explicit lifetimes could be elided: 'a --> merk/src/tree/iter.rs:68:6 | 68 | impl<'a> Iterator for Iter<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 68 - impl<'a> Iterator for Iter<'a> { 68 + impl Iterator for Iter<'_> { |

the following explicit lifetimes could be elided: 'a: merk/src/proofs/query/mod.rs#L705

warning: the following explicit lifetimes could be elided: 'a --> merk/src/proofs/query/mod.rs:705:6 | 705 | impl<'a, S> RefWalker<'a, S> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 705 - impl<'a, S> RefWalker<'a, S> 705 + impl<S> RefWalker<'_, S> |

the following explicit lifetimes could be elided: 'a: merk/src/proofs/query/map.rs#L162

warning: the following explicit lifetimes could be elided: 'a --> merk/src/proofs/query/map.rs:162:6 | 162 | impl<'a> Range<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 162 - impl<'a> Range<'a> { 162 + impl Range<'_> { |

the following explicit lifetimes could be elided: 'a: merk/src/proofs/encoding.rs#L417

warning: the following explicit lifetimes could be elided: 'a --> merk/src/proofs/encoding.rs:417:6 | 417 | impl<'a> Iterator for Decoder<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 417 - impl<'a> Iterator for Decoder<'a> { 417 + impl Iterator for Decoder<'_> { |

unneeded `return` statement: merk/src/proofs/chunk/chunk.rs#L217

warning: unneeded `return` statement --> merk/src/proofs/chunk/chunk.rs:217:5 | 217 | / return Ok(match height_proof_tree.child(LEFT) { 218 | | Some(child) => { 219 | | if !matches!(child.tree.node, Node::KVHash(..)) { 220 | | // todo deal with old chunk restoring error ... | 227 | | None => 1, 228 | | }); | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 217 ~ Ok(match height_proof_tree.child(LEFT) { 218 + Some(child) => { 219 + if !matches!(child.tree.node, Node::KVHash(..)) { 220 + // todo deal with old chunk restoring error 221 + return Err(Error::OldChunkRestoringError( 222 + "Expected left nodes in height proofs to be kvhash nodes".to_string(), 223 + )); 224 + } 225 + verify_height_tree(&child.tree)? + 1 226 + } 227 + None => 1, 228 ~ }) |

the following explicit lifetimes could be elided: 'a: merk/src/proofs/chunk/chunk.rs#L43

warning: the following explicit lifetimes could be elided: 'a --> merk/src/proofs/chunk/chunk.rs:43:6 | 43 | impl<'a, S> RefWalker<'a, S> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 43 - impl<'a, S> RefWalker<'a, S> 43 + impl<S> RefWalker<'_, S> |

module has the same name as its containing module: merk/src/proofs/chunk.rs#L5

warning: module has the same name as its containing module --> merk/src/proofs/chunk.rs:5:1 | 5 | pub mod chunk; | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default

this function has too many arguments (8/7): merk/src/merk/mod.rs#L660

warning: this function has too many arguments (8/7) --> merk/src/merk/mod.rs:660:5 | 660 | / fn verify_link( 661 | | &self, 662 | | link: &Link, 663 | | parent_key: &[u8], ... | 668 | | grove_version: &GroveVersion, 669 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

very complex type used. Consider factoring parts into `type` definitions: merk/src/merk/mod.rs#L600

warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/mod.rs:600:10 | 600 | ) -> (BTreeMap<Vec<u8>, CryptoHash>, BTreeMap<Vec<u8>, Vec<u8>>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

the following explicit lifetimes could be elided: 's: merk/src/merk/source.rs#L37

warning: the following explicit lifetimes could be elided: 's --> merk/src/merk/source.rs:37:6 | 37 | impl<'s, 'db, S> Fetch for MerkSource<'s, S> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 37 - impl<'s, 'db, S> Fetch for MerkSource<'s, S> 37 + impl<'db, S> Fetch for MerkSource<'_, S> |

the following explicit lifetimes could be elided: 's: merk/src/merk/source.rs#L28

warning: the following explicit lifetimes could be elided: 's --> merk/src/merk/source.rs:28:6 | 28 | impl<'s, S> Clone for MerkSource<'s, S> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 28 - impl<'s, S> Clone for MerkSource<'s, S> { 28 + impl<S> Clone for MerkSource<'_, S> { |

this function has too many arguments (10/7): merk/src/merk/apply.rs#L321

this function has too many arguments (10/7): merk/src/merk/apply.rs#L205

warning: this function has too many arguments (10/7) --> merk/src/merk/apply.rs:205:5 | 205 | / pub fn apply_with_costs_just_in_time_value_update<KB, KA>( 206 | | &mut self, 207 | | batch: &MerkBatch<KB>, 208 | | aux: &AuxMerkBatch<KA>, ... | 234 | | grove_version: &GroveVersion, 235 | | ) -> CostResult<(), Error> | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

very complex type used. Consider factoring parts into `type` definitions: merk/src/merk/chunks.rs#L393

warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/chunks.rs:393:10 | 393 | ) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: merk/src/merk/chunks.rs#L363

warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/chunks.rs:363:10 | 363 | ) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

method `apply_sorted_without_costs` is never used: merk/src/tree/ops.rs#L390

method `attempt_state_recovery` is never used: merk/src/merk/restore.rs#L412

warning: method `attempt_state_recovery` is never used --> merk/src/merk/restore.rs:412:8 | 67 | impl<'db, S: StorageContext<'db>> Restorer<S> { | --------------------------------------------- method in this implementation ... 412 | fn attempt_state_recovery(&mut self, grove_version: &GroveVersion) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

unexpected `cfg` condition name: `tests`: merk/src/tree/fuzz_tests.rs#L3

warning: unexpected `cfg` condition name: `tests` --> merk/src/tree/fuzz_tests.rs:3:8 | 3 | #![cfg(tests)] | ^^^^^ help: there is a config with a similar name: `test` | = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tests)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tests)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default

elided lifetime has a name: merk/src/proofs/query/map.rs#L110

warning: elided lifetime has a name --> merk/src/proofs/query/map.rs:110:72 | 110 | pub fn range<'a, R: RangeBounds<&'a [u8]>>(&'a self, bounds: R) -> Range { | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` | = note: `#[warn(elided_named_lifetimes)]` on by default

using `map` over `inspect`: storage/src/rocksdb_storage/storage_context/raw_iterator.rs#L214

warning: using `map` over `inspect` --> storage/src/rocksdb_storage/storage_context/raw_iterator.rs:214:39 | 214 | self.raw_iterator.value().map(|v| { | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect help: try | 214 ~ self.raw_iterator.value().inspect(|v| { 215 ~ cost.storage_loaded_bytes += v.len() as u64; |

using `map` over `inspect`: storage/src/rocksdb_storage/storage_context/raw_iterator.rs#L93

warning: using `map` over `inspect` --> storage/src/rocksdb_storage/storage_context/raw_iterator.rs:93:39 | 93 | self.raw_iterator.value().map(|v| { | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 93 ~ self.raw_iterator.value().inspect(|v| { 94 ~ cost.storage_loaded_bytes += v.len() as u64; |

the following explicit lifetimes could be elided: 'a: storage/src/rocksdb_storage/storage_context/raw_iterator.rs#L49

warning: the following explicit lifetimes could be elided: 'a --> storage/src/rocksdb_storage/storage_context/raw_iterator.rs:49:6 | 49 | impl<'a> RawIterator for PrefixedRocksDbRawIterator<DBRawIteratorWithThreadMode<'a, Db>> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 49 - impl<'a> RawIterator for PrefixedRocksDbRawIterator<DBRawIteratorWithThreadMode<'a, Db>> { 49 + impl RawIterator for PrefixedRocksDbRawIterator<DBRawIteratorWithThreadMode<'_, Db>> { |

the following explicit lifetimes could be elided: 'db: storage/src/rocksdb_storage/storage_context/batch.rs#L36

warning: the following explicit lifetimes could be elided: 'db --> storage/src/rocksdb_storage/storage_context/batch.rs:36:6 | 36 | impl<'db> Batch for PrefixedRocksDbBatch<'db> { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 36 - impl<'db> Batch for PrefixedRocksDbBatch<'db> { 36 + impl Batch for PrefixedRocksDbBatch<'_> { |

the following explicit lifetimes could be elided: 'b: path/src/subtree_path_iter.rs#L150

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path_iter.rs:150:6 | 150 | impl<'b, B> Clone for CurrentSubtreePathIter<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 150 - impl<'b, B> Clone for CurrentSubtreePathIter<'b, B> { 150 + impl Clone for CurrentSubtreePathIter<'_, B> { |

the following explicit lifetimes could be elided: 'b: path/src/subtree_path_iter.rs#L45

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path_iter.rs:45:6 | 45 | impl<'b, B> Clone for SubtreePathIter<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 45 - impl<'b, B> Clone for SubtreePathIter<'b, B> { 45 + impl Clone for SubtreePathIter<'_, B> { |

doc list item without indentation: costs/src/context.rs#L182

warning: doc list item without indentation --> costs/src/context.rs:182:5 | 182 | /// accumulator; | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 182 | /// accumulator; | +++

Linting

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Linting

Tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix/refactor: atomicity and caching #666

Summary

fix/refactor: atomicity and caching #666

Jobs

Run details

grovedb.yml

Annotations