warning: this function has too many arguments (8/7) --> grovedb/src/lib.rs:730:5 | 730 | / fn verify_merk_and_submerks_in_transaction<'db, B: AsRef<[u8]>, S: StorageContext<'db>>( 731 | | &'db self, 732 | | merk: Merk<S>, 733 | | path: &SubtreePath<B>, ... | 738 | | grove_version: &GroveVersion, 739 | | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | |___________________________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: very complex type used. Consider factoring parts into `type` definitions --> grovedb/src/lib.rs:739:10 | 739 | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: very complex type used. Consider factoring parts into `type` definitions --> grovedb/src/lib.rs:715:10 | 715 | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/util.rs:47:6 | 47 | impl<'a, 'db> AsRef<Transaction<'db>> for TxRef<'a, 'db> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 47 - impl<'a, 'db> AsRef<Transaction<'db>> for TxRef<'a, 'db> { 47 + impl<'db> AsRef<Transaction<'db>> for TxRef<'_, 'db> { |

warning: the following explicit lifetimes could be elided: 'db --> grovedb/src/replication.rs:49:6 | 49 | impl<'db> Default for MultiStateSyncInfo<'db> { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 49 - impl<'db> Default for MultiStateSyncInfo<'db> { 49 + impl Default for MultiStateSyncInfo<'_> { |

warning: calling `push_str()` using a single-character string literal --> grovedb/src/reference_path.rs:142:17 | 142 | hx.push_str(")"); | ^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `hx.push(')')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str

warning: calling `push_str()` using a single-character string literal --> grovedb/src/reference_path.rs:140:17 | 140 | hx.push_str("("); | ^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `hx.push('(')` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str = note: `#[warn(clippy::single_char_add_str)]` on by default

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/query/mod.rs:512:6 | 512 | impl<'a> fmt::Display for SinglePathSubquery<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 512 - impl<'a> fmt::Display for SinglePathSubquery<'a> { 512 + impl fmt::Display for SinglePathSubquery<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/query/mod.rs:483:6 | 483 | impl<'a> HasSubquery<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 483 - impl<'a> HasSubquery<'a> { 483 + impl HasSubquery<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/query/mod.rs:467:6 | 467 | impl<'a> fmt::Display for HasSubquery<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 467 - impl<'a> fmt::Display for HasSubquery<'a> { 467 + impl fmt::Display for HasSubquery<'_> { |

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/verify.rs:366:25 | 366 | limit_left.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = limit_left.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/verify.rs:292:17 | 292 | limit_left.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = limit_left.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn = note: `#[warn(clippy::option_map_unit_fn)]` on by default

warning: this function has too many arguments (8/7) --> grovedb/src/operations/proof/verify.rs:228:5 | 228 | / fn verify_layer_proof<T>( 229 | | layer_proof: &LayerProof, 230 | | prove_options: &ProveOptions, 231 | | query: &PathQuery, ... | 236 | | grove_version: &GroveVersion, 237 | | ) -> Result<CryptoHash, Error> | |__________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/operations/proof/generate.rs:216:74 | 216 | self.open_transactional_merk_at_path(path.as_slice().into(), &tx, None, grove_version) | ^^^ help: change this to: `tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this function has too many arguments (8/7) --> grovedb/src/operations/insert/mod.rs:104:5 | 104 | / fn add_element_on_transaction<'db, 'b, 'c, B: AsRef<[u8]>>( 105 | | &'db self, 106 | | path: SubtreePath<'b, B>, 107 | | key: &[u8], ... | 114 | | grove_version: &GroveVersion, 115 | | ) -> CostResult<MerkHandle<'db, 'c>, Error> { | |_______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/operations/insert/mod.rs:75:41 | 75 | let merk_cache = MerkCache::new(&self, tx.as_ref(), grove_version); | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this function has too many arguments (8/7) --> grovedb/src/operations/get/query.rs:545:5 | 545 | / pub fn query_raw( 546 | | &self, 547 | | path_query: &PathQuery, 548 | | allow_cache: bool, ... | 553 | | grove_version: &GroveVersion, 554 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/operations/get/query.rs:230:5 | 230 | / pub fn query( 231 | | &self, 232 | | path_query: &PathQuery, 233 | | allow_cache: bool, ... | 238 | | grove_version: &GroveVersion, 239 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/operations/get/query.rs:113:5 | 113 | / pub fn query_many_raw( 114 | | &self, 115 | | path_queries: &[&PathQuery], 116 | | allow_cache: bool, ... | 121 | | grove_version: &GroveVersion, 122 | | ) -> CostResult<QueryResultElements, Error> | |_______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/mod.rs:579:5 | 579 | / fn delete_internal<B: AsRef<[u8]>>( 580 | | &self, 581 | | path: SubtreePath<B>, 582 | | key: &[u8], ... | 594 | | grove_version: &GroveVersion, 595 | | ) -> CostResult<bool, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/mod.rs:446:5 | 446 | / pub fn delete_operation_for_delete_internal<B: AsRef<[u8]>>( 447 | | &self, 448 | | path: SubtreePath<B>, 449 | | key: &[u8], ... | 454 | | grove_version: &GroveVersion, 455 | | ) -> CostResult<Option<QualifiedGroveDbOp>, Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/worst_case.rs:119:5 | 119 | / pub fn worst_case_delete_operation_for_delete<'db, S: Storage<'db>>( 120 | | path: &KeyInfoPath, 121 | | key: &KeyInfo, 122 | | parent_tree_is_sum_tree: bool, ... | 127 | | grove_version: &GroveVersion, 128 | | ) -> CostResult<QualifiedGroveDbOp, Error> { | |______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/delete_up_tree.rs:197:5 | 197 | / pub fn add_delete_operations_for_delete_up_tree_while_empty<B: AsRef<[u8]>>( 198 | | &self, 199 | | path: SubtreePath<B>, 200 | | key: &[u8], ... | 205 | | grove_version: &GroveVersion, 206 | | ) -> CostResult<Option<Vec<QualifiedGroveDbOp>>, Error> { | |___________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/delete_up_tree.rs:165:5 | 165 | / pub fn delete_operations_for_delete_up_tree_while_empty<B: AsRef<[u8]>>( 166 | | &self, 167 | | path: SubtreePath<B>, 168 | | key: &[u8], ... | 173 | | grove_version: &GroveVersion, 174 | | ) -> CostResult<Vec<QualifiedGroveDbOp>, Error> { | |___________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/operations/delete/average_case.rs:139:5 | 139 | / pub fn average_case_delete_operation_for_delete<'db, S: Storage<'db>>( 140 | | path: &KeyInfoPath, 141 | | key: &KeyInfo, 142 | | parent_tree_is_sum_tree: bool, ... | 147 | | grove_version: &GroveVersion, 148 | | ) -> CostResult<QualifiedGroveDbOp, Error> { | |______________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: the following explicit lifetimes could be elided: 'c --> grovedb/src/merk_cache.rs:174:11 | 174 | impl<'db, 'c> MerkHandle<'db, 'c> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 174 - impl<'db, 'c> MerkHandle<'db, 'c> { 174 + impl<'db> MerkHandle<'db, '_> { |

warning: very complex type used. Consider factoring parts into `type` definitions --> grovedb/src/merk_cache.rs:24:12 | 24 | merks: UnsafeCell<BTreeMap<SubtreePathBuilder<'b, B>, Box<(Cell<bool>, TxMerk<'db>)>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: this function has too many arguments (12/7) --> grovedb/src/element/query.rs:712:5 | 712 | / fn query_item( 713 | | storage: &RocksDbStorage, 714 | | item: &QueryItem, 715 | | results: &mut Vec<QueryResultElement>, ... | 724 | | grove_version: &GroveVersion, 725 | | ) -> CostResult<(), Error> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/element/query.rs:302:5 | 302 | / pub fn get_query_apply_function( 303 | | storage: &RocksDbStorage, 304 | | path: &[&[u8]], 305 | | sized_query: &SizedQuery, ... | 310 | | grove_version: &GroveVersion, 311 | | ) -> CostResult<(QueryResultElements, u16), Error> { | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/element/query.rs:172:17 | 172 | impl<'db, 'ctx, 'a> fmt::Display for PathQueryPushArgs<'db, 'ctx, 'a> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 172 - impl<'db, 'ctx, 'a> fmt::Display for PathQueryPushArgs<'db, 'ctx, 'a> 172 + impl<'db, 'ctx> fmt::Display for PathQueryPushArgs<'db, 'ctx, '_> |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/element/insert.rs:514:32 | 514 | Self::get_optional(&merk, &key, true, grove_version) | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/element/insert.rs:360:32 | 360 | Self::get_optional(&merk, &key, true, grove_version) | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/element/insert.rs:223:32 | 223 | Self::get_optional(&merk, key, true, grove_version) | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this `let...else` may be rewritten with the `?` operator --> grovedb/src/element/helpers.rs:328:9 | 328 | / let Some(value_cost) = self.get_specialized_cost(grove_version).ok() else { 329 | | return None; 330 | | }; | |__________^ help: replace it with: `let value_cost = self.get_specialized_cost(grove_version).ok()?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `#[warn(clippy::question_mark)]` on by default

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> grovedb/src/element/helpers.rs:253:14 | 253 | key: &Vec<u8>, | ^^^^^^^^ help: change this to: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/debugger.rs:335:29 | 335 | ... &tx, | ^^^ help: change this to: `tx` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:2335:5 | 2335 | / pub fn apply_partial_batch_with_element_flags_update( 2336 | | &self, 2337 | | ops: Vec<QualifiedGroveDbOp>, 2338 | | batch_apply_options: Option<BatchApplyOptions>, ... | 2357 | | grove_version: &GroveVersion, 2358 | | ) -> CostResult<(), Error> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:1973:5 | 1973 | / fn continue_partial_apply_body<'db, S: StorageContext<'db>>( 1974 | | &self, 1975 | | previous_leftover_operations: Option<OpsByLevelPath>, 1976 | | additional_ops: Vec<QualifiedGroveDbOp>, ... | 1992 | | grove_version: &GroveVersion, 1993 | | ) -> CostResult<Option<OpsByLevelPath>, Error> { | |__________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: useless conversion to the same type: `batch::GroveOp` --> grovedb/src/batch/mod.rs:1899:37 | 1899 | / ... GroveOp::ReplaceTreeRootKey { 1900 | | ... hash: root_hash, 1901 | | ... root_key: calculated_root_key, 1902 | | ... sum: sum_value, 1903 | | ... } 1904 | | ... .into(), | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 1899 ~ GroveOp::ReplaceTreeRootKey { 1900 + hash: root_hash, 1901 + root_key: calculated_root_key, 1902 + sum: sum_value, 1903 ~ }, |

warning: useless conversion to the same type: `batch::GroveOp` --> grovedb/src/batch/mod.rs:1847:61 | 1847 | / ... GroveOp::InsertTreeWithRootHash { 1848 | | ... hash: root_hash, 1849 | | ... root_key: calculated_root_key, 1850 | | ... flags: flags.clone(), 1851 | | ... sum: sum_value, 1852 | | ... } 1853 | | ... .into(); | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 1847 ~ GroveOp::InsertTreeWithRootHash { 1848 + hash: root_hash, 1849 + root_key: calculated_root_key, 1850 + flags: flags.clone(), 1851 + sum: sum_value, 1852 ~ }; |

warning: useless conversion to the same type: `batch::GroveOp` --> grovedb/src/batch/mod.rs:1836:61 | 1836 | / ... GroveOp::InsertTreeWithRootHash { 1837 | | ... hash: root_hash, 1838 | | ... root_key: calculated_root_key, 1839 | | ... flags: flags.clone(), 1840 | | ... sum: None, 1841 | | ... } 1842 | | ... .into(); | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion help: consider removing `.into()` | 1836 ~ GroveOp::InsertTreeWithRootHash { 1837 + hash: root_hash, 1838 + root_key: calculated_root_key, 1839 + flags: flags.clone(), 1840 + sum: None, 1841 ~ }; |

warning: useless conversion to the same type: `batch::GroveOp` --> grovedb/src/batch/mod.rs:1804:49 | 1804 | / ... GroveOp::ReplaceTreeRootKey { 1805 | | ... hash: root_hash, 1806 | | ... root_key: calculated_root_key, 1807 | | ... sum: sum_value, 1808 | | ... } 1809 | | ... .into(), | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default help: consider removing `.into()` | 1804 ~ GroveOp::ReplaceTreeRootKey { 1805 + hash: root_hash, 1806 + root_key: calculated_root_key, 1807 + sum: sum_value, 1808 ~ }, |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/batch/mod.rs:1542:29 | 1542 | ... &merk, | ^^^^^ help: change this to: `merk` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: returning the result of a `let` binding from a block --> grovedb/src/batch/mod.rs:1695:9 | 1690 | / let r = merk 1691 | | .root_hash_key_and_sum() 1692 | | .add_cost(cost) 1693 | | .map_err(Error::MerkError); | |_______________________________________- unnecessary `let` binding 1694 | 1695 | r | ^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 1690 ~ 1691 | 1692 ~ merk 1693 + .root_hash_key_and_sum() 1694 + .add_cost(cost) 1695 + .map_err(Error::MerkError) |

warning: this function has too many arguments (9/7) --> grovedb/src/batch/mod.rs:969:5 | 969 | / fn process_reference_with_hop_count_greater_than_one<'a, G, SR>( 970 | | &'a mut self, 971 | | key: &[u8], 972 | | reference_path: &[Vec<u8>], ... | 978 | | grove_version: &GroveVersion, 979 | | ) -> CostResult<CryptoHash, Error> | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/batch/mod.rs:879:47 | 879 | fn get_and_deserialize_referenced_element<'a>( | ^^ 880 | &'a mut self, | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 879 ~ fn get_and_deserialize_referenced_element( 880 ~ &mut self, |

warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:751:5 | 751 | / fn process_reference<'a, G, SR>( 752 | | &'a mut self, 753 | | qualified_path: &[Vec<u8>], 754 | | ops_by_qualified_paths: &'a BTreeMap<Vec<Vec<u8>>, GroveOp>, ... | 759 | | grove_version: &GroveVersion, 760 | | ) -> CostResult<CryptoHash, Error> | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:738:9 | 738 | /// missing reference, corrupted data, or invalid batch operation. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 738 | /// missing reference, corrupted data, or invalid batch operation. | ++

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:734:9 | 734 | /// associated cost, if successful. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 734 | /// associated cost, if successful. | ++

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:721:9 | 721 | /// element. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 721 | /// element. | +++

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:720:9 | 720 | /// element and then determines the next step based on the type of the | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 720 | /// element and then determines the next step based on the type of the | +++

warning: doc list item without indentation --> grovedb/src/batch/mod.rs:717:9 | 717 | /// value hash from the reference element. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 717 | /// value hash from the reference element. | +++

warning: this function has too many arguments (8/7) --> grovedb/src/batch/mod.rs:687:5 | 687 | / fn execute_ops_on_path( 688 | | &mut self, 689 | | path: &KeyInfoPath, 690 | | ops_at_path_by_key: BTreeMap<KeyInfo, GroveOp>, ... | 695 | | grove_version: &GroveVersion, 696 | | ) -> CostResult<RootHashKeyAndSum, Error>; | |_____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/batch/just_in_time_reference_update.rs:62:47 | 62 | let val_hash = value_hash(&serialized).unwrap_add_cost(&mut cost); | ^^^^^^^^^^^ help: change this to: `serialized` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: this function has too many arguments (9/7) --> grovedb/src/batch/just_in_time_reference_update.rs:28:5 | 28 | / pub(crate) fn process_old_element_flags<G, SR>( 29 | | key: &[u8], 30 | | serialized: &[u8], 31 | | new_element: &mut Element, ... | 37 | | grove_version: &GroveVersion, 38 | | ) -> CostResult<CryptoHash, Error> | |______________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: usage of `contains_key` followed by `insert` on a `HashMap` --> grovedb/src/batch/estimated_costs/average_case_costs.rs:273:13 | 273 | / if !self.cached_merks.contains_key(&base_path) { 274 | | cost_return_on_error_no_add!( 275 | | cost, 276 | | GroveDb::add_average_case_get_merk_at_path::<RocksDbStorage>( ... | 287 | | .insert(base_path, estimated_layer_info.is_sum_tree); 288 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 273 ~ if let std::collections::hash_map::Entry::Vacant(e) = self.cached_merks.entry(base_path) { 274 + cost_return_on_error_no_add!( 275 + cost, 276 + GroveDb::add_average_case_get_merk_at_path::<RocksDbStorage>( 277 + &mut cost, 278 + &base_path, 279 + estimated_layer_info 280 + .estimated_layer_count 281 + .estimated_to_be_empty(), 282 + estimated_layer_info.is_sum_tree, 283 + grove_version 284 + ) 285 + ); 286 + e.insert(estimated_layer_info.is_sum_tree); 287 + } |

warning: unnecessary use of `get(path).is_none()` --> grovedb/src/batch/estimated_costs/average_case_costs.rs:219:30 | 219 | if self.cached_merks.get(path).is_none() { | ------------------^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!self.cached_merks.contains_key(path)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default

warning: function `follow_reference_once` is never used --> grovedb/src/util.rs:209:15 | 209 | pub(crate) fn follow_reference_once<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^

warning: function `follow_reference` is never used --> grovedb/src/util.rs:125:15 | 125 | pub(crate) fn follow_reference<'db, 'b, 'c, B: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^

warning: struct `ResolvedReference` is never constructed --> grovedb/src/util.rs:117:19 | 117 | pub(crate) struct ResolvedReference<'db, 'b, 'c, B> { | ^^^^^^^^^^^^^^^^^

warning: method `invert` is never used --> grovedb/src/reference_path.rs:66:19 | 64 | impl ReferencePathType { | ---------------------- method in this implementation 65 | /// Get an inverted reference 66 | pub(crate) fn invert<B: AsRef<[u8]>>(&self, path: SubtreePath<B>, key: &[u8]) -> Option<Self> { | ^^^^^^

warning: variants `Execute`, `AverageCase`, and `WorstCase` are never constructed --> grovedb/src/batch/mode.rs:18:5 | 17 | pub enum BatchRunMode { | ------------ variants in this enum 18 | Execute, | ^^^^^^^ 19 | #[cfg(feature = "estimated_costs")] 20 | AverageCase(HashMap<KeyInfoPath, EstimatedLayerInformation>), | ^^^^^^^^^^^ 21 | #[cfg(feature = "estimated_costs")] 22 | WorstCase(HashMap<KeyInfoPath, WorstCaseLayerInformation>), | ^^^^^^^^^ | = note: `BatchRunMode` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis

warning: method `get_batch_run_mode` is never used --> grovedb/src/batch/mod.rs:684:8 | 681 | trait TreeCache<G, SR> { | --------- method in this trait ... 684 | fn get_batch_run_mode(&self) -> BatchRunMode; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: elided lifetime has a name --> grovedb/src/replication.rs:572:32 | 566 | fn discover_subtrees<'db>( | --- lifetime `'db` declared here ... 572 | ) -> Result<(Vec<Vec<u8>>, MultiStateSyncInfo), Error> { | ^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'db`

warning: elided lifetime has a name --> grovedb/src/replication.rs:510:32 | 504 | fn apply_inner_chunk<'db>( | --- lifetime `'db` declared here ... 510 | ) -> Result<(Vec<Vec<u8>>, SubtreeStateSyncInfo), Error> { | ^^^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'db`

warning: elided lifetime has a name --> grovedb/src/replication.rs:393:32 | 385 | pub fn apply_chunk<'db>( | --- lifetime `'db` declared here ... 393 | ) -> Result<(Vec<Vec<u8>>, MultiStateSyncInfo), Error> { | ^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'db`

warning: elided lifetime has a name --> grovedb/src/replication.rs:325:17 | 318 | pub fn start_snapshot_syncing<'db>( | --- lifetime `'db` declared here ... 325 | ) -> Result<MultiStateSyncInfo, Error> { | ^^^^^^^^^^^^^^^^^^ this elided lifetime gets resolved as `'db` | = note: `#[warn(elided_named_lifetimes)]` on by default

warning: unused import: `error::GroveVersionError` --> grovedb/src/replication.rs:17:41 | 17 | use grovedb_version::{check_grovedb_v0, error::GroveVersionError, version::GroveVersion}; | ^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused import: `error::GroveVersionError` --> grovedb/src/operations/delete/average_case.rs:15:33 | 15 | check_grovedb_v0_with_cost, error::GroveVersionError, version::GroveVersion, | ^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: the following explicit lifetimes could be elided: 'a --> merk/src/visualize.rs:87:6 | 87 | impl<'a, T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize for VisualizableTree<'a, F> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 87 - impl<'a, T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize for VisualizableTree<'a, F> { 87 + impl<T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize for VisualizableTree<'_, F> { |

warning: the following explicit lifetimes could be elided: 'a --> merk/src/visualize.rs:68:6 | 68 | impl<'a, 'db, S: StorageContext<'db>, T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize | ^^ 69 | for VisualizeableMerk<'a, S, F> | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 68 ~ impl<'db, S: StorageContext<'db>, T: Visualize, F: Fn(&[u8]) -> T + Copy> Visualize 69 ~ for VisualizeableMerk<'_, S, F> |

warning: casting to the same type is unnecessary (`u32` -> `u32`) --> merk/src/estimated_costs/average_case_costs.rs:423:24 | 423 | cost.seek_count += nodes_updated as u32; | ^^^^^^^^^^^^^^^^^^^^ help: try: `nodes_updated` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: duplicated attribute --> merk/src/estimated_costs/average_case_costs.rs:49:7 | 49 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ | note: first defined here --> merk/src/estimated_costs/average_case_costs.rs:48:7 | 48 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ help: remove this attribute --> merk/src/estimated_costs/average_case_costs.rs:49:7 | 49 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes = note: `#[warn(clippy::duplicated_attributes)]` on by default

warning: this function has too many arguments (9/7) --> merk/src/tree/mod.rs:850:5 | 850 | / pub fn put_value_with_reference_value_hash_and_value_cost( 851 | | mut self, 852 | | value: Vec<u8>, 853 | | value_hash: CryptoHash, ... | 876 | | >, 877 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> merk/src/tree/mod.rs:792:5 | 792 | / pub fn put_value_and_reference_value_hash( 793 | | mut self, 794 | | value: Vec<u8>, 795 | | value_hash: CryptoHash, ... | 817 | | >, 818 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> merk/src/tree/mod.rs:736:5 | 736 | / pub fn put_value_with_fixed_cost( 737 | | mut self, 738 | | value: Vec<u8>, 739 | | value_fixed_cost: u32, ... | 761 | | >, 762 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (9/7) --> merk/src/tree/walk/mod.rs:341:5 | 341 | / pub fn put_value_with_reference_value_hash_and_value_cost( 342 | | mut self, 343 | | value: Vec<u8>, 344 | | value_hash: CryptoHash, ... | 367 | | >, 368 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> merk/src/tree/walk/mod.rs:295:5 | 295 | / pub fn put_value_and_reference_value_hash( 296 | | mut self, 297 | | value: Vec<u8>, 298 | | value_hash: CryptoHash, ... | 320 | | >, 321 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> merk/src/tree/walk/mod.rs:249:5 | 249 | / pub fn put_value_with_fixed_cost( 250 | | mut self, 251 | | value: Vec<u8>, 252 | | value_fixed_cost: u32, ... | 274 | | >, 275 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (11/7) --> merk/src/tree/ops.rs:733:5 | 733 | / fn recurse<K: AsRef<[u8]>, C, V, T, U, R>( 734 | | self, 735 | | batch: &MerkBatch<K>, 736 | | mid: usize, ... | 744 | | grove_version: &GroveVersion, 745 | | ) -> CostResult<(Option<Self>, KeyUpdates), Error> | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> merk/src/tree/ops.rs:415:5 | 415 | / fn apply_sorted<K: AsRef<[u8]>, C, V, T, U, R>( 416 | | self, 417 | | batch: &MerkBatch<K>, 418 | | old_specialized_cost: &C, ... | 423 | | grove_version: &GroveVersion, 424 | | ) -> CostResult<(Option<Self>, KeyUpdates), Error> | |______________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (8/7) --> merk/src/tree/ops.rs:235:5 | 235 | / fn build<K: AsRef<[u8]>, C, V, T, U, R>( 236 | | batch: &MerkBatch<K>, 237 | | source: S, 238 | | old_tree_cost: &C, ... | 243 | | grove_version: &GroveVersion, 244 | | ) -> CostResult<Option<TreeNode>, Error> | |____________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (9/7) --> merk/src/tree/ops.rs:148:5 | 148 | / pub fn apply_to<K: AsRef<[u8]>, C, V, T, U, R>( 149 | | maybe_tree: Option<Self>, 150 | | batch: &MerkBatch<K>, 151 | | source: S, ... | 157 | | grove_version: &GroveVersion, 158 | | ) -> CostContext<Result<(Option<TreeNode>, KeyUpdates), Error>> | |___________________________________________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: the following explicit lifetimes could be elided: 'a --> merk/src/tree/iter.rs:68:6 | 68 | impl<'a> Iterator for Iter<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 68 - impl<'a> Iterator for Iter<'a> { 68 + impl Iterator for Iter<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> merk/src/proofs/query/mod.rs:705:6 | 705 | impl<'a, S> RefWalker<'a, S> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 705 - impl<'a, S> RefWalker<'a, S> 705 + impl<S> RefWalker<'_, S> |

warning: the following explicit lifetimes could be elided: 'a --> merk/src/proofs/query/map.rs:162:6 | 162 | impl<'a> Range<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 162 - impl<'a> Range<'a> { 162 + impl Range<'_> { |

warning: the following explicit lifetimes could be elided: 'a --> merk/src/proofs/encoding.rs:417:6 | 417 | impl<'a> Iterator for Decoder<'a> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 417 - impl<'a> Iterator for Decoder<'a> { 417 + impl Iterator for Decoder<'_> { |

warning: unneeded `return` statement --> merk/src/proofs/chunk/chunk.rs:217:5 | 217 | / return Ok(match height_proof_tree.child(LEFT) { 218 | | Some(child) => { 219 | | if !matches!(child.tree.node, Node::KVHash(..)) { 220 | | // todo deal with old chunk restoring error ... | 227 | | None => 1, 228 | | }); | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 217 ~ Ok(match height_proof_tree.child(LEFT) { 218 + Some(child) => { 219 + if !matches!(child.tree.node, Node::KVHash(..)) { 220 + // todo deal with old chunk restoring error 221 + return Err(Error::OldChunkRestoringError( 222 + "Expected left nodes in height proofs to be kvhash nodes".to_string(), 223 + )); 224 + } 225 + verify_height_tree(&child.tree)? + 1 226 + } 227 + None => 1, 228 ~ }) |

warning: the following explicit lifetimes could be elided: 'a --> merk/src/proofs/chunk/chunk.rs:43:6 | 43 | impl<'a, S> RefWalker<'a, S> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 43 - impl<'a, S> RefWalker<'a, S> 43 + impl<S> RefWalker<'_, S> |

warning: module has the same name as its containing module --> merk/src/proofs/chunk.rs:5:1 | 5 | pub mod chunk; | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default

warning: this function has too many arguments (8/7) --> merk/src/merk/mod.rs:660:5 | 660 | / fn verify_link( 661 | | &self, 662 | | link: &Link, 663 | | parent_key: &[u8], ... | 668 | | grove_version: &GroveVersion, 669 | | ) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/mod.rs:600:10 | 600 | ) -> (BTreeMap<Vec<u8>, CryptoHash>, BTreeMap<Vec<u8>, Vec<u8>>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: the following explicit lifetimes could be elided: 'a --> merk/src/merk/mod.rs:192:6 | 192 | impl<'a, I: RawIterator> KVIterator<'a, I> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 192 - impl<'a, I: RawIterator> KVIterator<'a, I> { 192 + impl<I: RawIterator> KVIterator<'_, I> { |

warning: the following explicit lifetimes could be elided: 's --> merk/src/merk/source.rs:37:6 | 37 | impl<'s, 'db, S> Fetch for MerkSource<'s, S> | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 37 - impl<'s, 'db, S> Fetch for MerkSource<'s, S> 37 + impl<'db, S> Fetch for MerkSource<'_, S> |

warning: the following explicit lifetimes could be elided: 's --> merk/src/merk/source.rs:28:6 | 28 | impl<'s, S> Clone for MerkSource<'s, S> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 28 - impl<'s, S> Clone for MerkSource<'s, S> { 28 + impl<S> Clone for MerkSource<'_, S> { |

warning: the borrowed expression implements the required traits --> merk/src/merk/meta.rs:37:26 | 37 | .delete_meta(&key, None) | ^^^^ help: change this to: `key` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: the following explicit lifetimes could be elided: 's --> merk/src/merk/meta.rs:13:21 | 13 | pub fn get_meta<'s>(&'s mut self, key: Vec<u8>) -> CostResult<Option<&'s [u8]>, Error> { | ^^ ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 13 - pub fn get_meta<'s>(&'s mut self, key: Vec<u8>) -> CostResult<Option<&'s [u8]>, Error> { 13 + pub fn get_meta(&mut self, key: Vec<u8>) -> CostResult<Option<&[u8]>, Error> { |

warning: this function has too many arguments (10/7) --> merk/src/merk/apply.rs:321:5 | 321 | / pub fn apply_unchecked<KB, KA, C, V, T, U, R>( 322 | | &mut self, 323 | | batch: &MerkBatch<KB>, 324 | | aux: &AuxMerkBatch<KA>, ... | 331 | | grove_version: &GroveVersion, 332 | | ) -> CostResult<(), Error> | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

warning: this function has too many arguments (10/7) --> merk/src/merk/apply.rs:205:5 | 205 | / pub fn apply_with_costs_just_in_time_value_update<KB, KA>( 206 | | &mut self, 207 | | batch: &MerkBatch<KB>, 208 | | aux: &AuxMerkBatch<KA>, ... | 234 | | grove_version: &GroveVersion, 235 | | ) -> CostResult<(), Error> | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/chunks.rs:393:10 | 393 | ) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/chunks.rs:363:10 | 363 | ) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

warning: method `apply_sorted_without_costs` is never used --> merk/src/tree/ops.rs:390:19 | 139 | / impl<S> Walker<S> 140 | | where 141 | | S: Fetch + Sized + Clone, | |_____________________________- method in this implementation ... 390 | pub(crate) fn apply_sorted_without_costs<K: AsRef<[u8]>>( | ^^^^^^^^^^^^^^^^^^^^^^^^^^

warning: method `attempt_state_recovery` is never used --> merk/src/merk/restore.rs:412:8 | 67 | impl<'db, S: StorageContext<'db>> Restorer<S> { | --------------------------------------------- method in this implementation ... 412 | fn attempt_state_recovery(&mut self, grove_version: &GroveVersion) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: unexpected `cfg` condition name: `tests` --> merk/src/tree/fuzz_tests.rs:3:8 | 3 | #![cfg(tests)] | ^^^^^ help: there is a config with a similar name: `test` | = help: consider using a Cargo feature instead = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [lints.rust] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tests)'] } = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tests)");` to the top of the `build.rs` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `#[warn(unexpected_cfgs)]` on by default

warning: elided lifetime has a name --> merk/src/proofs/query/map.rs:110:72 | 110 | pub fn range<'a, R: RangeBounds<&'a [u8]>>(&'a self, bounds: R) -> Range { | -- lifetime `'a` declared here ^^^^^ this elided lifetime gets resolved as `'a` | = note: `#[warn(elided_named_lifetimes)]` on by default

warning: struct `StorageBatch` has a public `len` method, but no `is_empty` method --> storage/src/storage.rs:309:5 | 309 | pub fn len(&self) -> usize { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty = note: `#[warn(clippy::len_without_is_empty)]` on by default

warning: using `map` over `inspect` --> storage/src/rocksdb_storage/storage_context/raw_iterator.rs:214:39 | 214 | self.raw_iterator.value().map(|v| { | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect help: try | 214 ~ self.raw_iterator.value().inspect(|v| { 215 ~ cost.storage_loaded_bytes += v.len() as u64; |

warning: using `map` over `inspect` --> storage/src/rocksdb_storage/storage_context/raw_iterator.rs:93:39 | 93 | self.raw_iterator.value().map(|v| { | ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect = note: `#[warn(clippy::manual_inspect)]` on by default help: try | 93 ~ self.raw_iterator.value().inspect(|v| { 94 ~ cost.storage_loaded_bytes += v.len() as u64; |

warning: the following explicit lifetimes could be elided: 'a --> storage/src/rocksdb_storage/storage_context/raw_iterator.rs:49:6 | 49 | impl<'a> RawIterator for PrefixedRocksDbRawIterator<DBRawIteratorWithThreadMode<'a, Db>> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 49 - impl<'a> RawIterator for PrefixedRocksDbRawIterator<DBRawIteratorWithThreadMode<'a, Db>> { 49 + impl RawIterator for PrefixedRocksDbRawIterator<DBRawIteratorWithThreadMode<'_, Db>> { |

warning: the following explicit lifetimes could be elided: 'db --> storage/src/rocksdb_storage/storage_context/batch.rs:36:6 | 36 | impl<'db> Batch for PrefixedRocksDbBatch<'db> { | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 36 - impl<'db> Batch for PrefixedRocksDbBatch<'db> { 36 + impl Batch for PrefixedRocksDbBatch<'_> { |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path_iter.rs:150:6 | 150 | impl<'b, B> Clone for CurrentSubtreePathIter<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 150 - impl<'b, B> Clone for CurrentSubtreePathIter<'b, B> { 150 + impl<B> Clone for CurrentSubtreePathIter<'_, B> { |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path_iter.rs:45:6 | 45 | impl<'b, B> Clone for SubtreePathIter<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 45 - impl<'b, B> Clone for SubtreePathIter<'b, B> { 45 + impl<B> Clone for SubtreePathIter<'_, B> { |

warning: the following explicit lifetimes could be elided: 'a --> path/src/subtree_path_builder.rs:178:28 | 178 | pub fn owned_from_path<'a, S: AsRef<[u8]>>(path: SubtreePath<'a, S>) -> Self { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 178 - pub fn owned_from_path<'a, S: AsRef<[u8]>>(path: SubtreePath<'a, S>) -> Self { 178 + pub fn owned_from_path<S: AsRef<[u8]>>(path: SubtreePath<'_, S>) -> Self { |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path_builder.rs:161:6 | 161 | impl<'b, B> SubtreePathBuilder<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 161 - impl<'b, B> SubtreePathBuilder<'b, B> { 161 + impl<B> SubtreePathBuilder<'_, B> { |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path_builder.rs:97:6 | 97 | impl<'b, B: AsRef<[u8]>> Eq for SubtreePathBuilder<'b, B> {} | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 97 - impl<'b, B: AsRef<[u8]>> Eq for SubtreePathBuilder<'b, B> {} 97 + impl<B: AsRef<[u8]>> Eq for SubtreePathBuilder<'_, B> {} |

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path_builder.rs:87:6 | 87 | impl<'bl, 'br, BL, BR> PartialEq<SubtreePath<'br, BR>> for SubtreePathBuilder<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 87 - impl<'bl, 'br, BL, BR> PartialEq<SubtreePath<'br, BR>> for SubtreePathBuilder<'bl, BL> 87 + impl<'br, BL, BR> PartialEq<SubtreePath<'br, BR>> for SubtreePathBuilder<'_, BL> |

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path_builder.rs:77:6 | 77 | impl<'bl, 'br, BL, BR> PartialEq<SubtreePathBuilder<'br, BR>> for SubtreePath<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 77 - impl<'bl, 'br, BL, BR> PartialEq<SubtreePathBuilder<'br, BR>> for SubtreePath<'bl, BL> 77 + impl<'br, BL, BR> PartialEq<SubtreePathBuilder<'br, BR>> for SubtreePath<'_, BL> |

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path_builder.rs:67:6 | 67 | impl<'bl, 'br, BL, BR> PartialEq<SubtreePathBuilder<'br, BR>> for SubtreePathBuilder<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 67 - impl<'bl, 'br, BL, BR> PartialEq<SubtreePathBuilder<'br, BR>> for SubtreePathBuilder<'bl, BL> 67 + impl<'br, BL, BR> PartialEq<SubtreePathBuilder<'br, BR>> for SubtreePathBuilder<'_, BL> |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path_builder.rs:60:6 | 60 | impl<'b, B: AsRef<[u8]>> Hash for SubtreePathBuilder<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 60 - impl<'b, B: AsRef<[u8]>> Hash for SubtreePathBuilder<'b, B> { 60 + impl<B: AsRef<[u8]>> Hash for SubtreePathBuilder<'_, B> { |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path_builder.rs:49:6 | 49 | impl<'b, B> Clone for SubtreePathBuilder<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 49 - impl<'b, B> Clone for SubtreePathBuilder<'b, B> { 49 + impl<B> Clone for SubtreePathBuilder<'_, B> { |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path.rs:214:6 | 214 | impl<'b, B: AsRef<[u8]>> Hash for SubtreePath<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 214 - impl<'b, B: AsRef<[u8]>> Hash for SubtreePath<'b, B> { 214 + impl<B: AsRef<[u8]>> Hash for SubtreePath<'_, B> { |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path.rs:184:6 | 184 | impl<'b, B: AsRef<[u8]>> Eq for SubtreePath<'b, B> {} | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 184 - impl<'b, B: AsRef<[u8]>> Eq for SubtreePath<'b, B> {} 184 + impl<B: AsRef<[u8]>> Eq for SubtreePath<'_, B> {} |

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path.rs:175:6 | 175 | impl<'bl, BL> Ord for SubtreePathBuilder<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 175 - impl<'bl, BL> Ord for SubtreePathBuilder<'bl, BL> 175 + impl<BL> Ord for SubtreePathBuilder<'_, BL> |

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path.rs:166:6 | 166 | impl<'bl, BL> Ord for SubtreePath<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 166 - impl<'bl, BL> Ord for SubtreePath<'bl, BL> 166 + impl<BL> Ord for SubtreePath<'_, BL> |

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path.rs:156:6 | 156 | impl<'bl, 'br, BL, BR> PartialOrd<SubtreePathBuilder<'br, BR>> for SubtreePath<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 156 - impl<'bl, 'br, BL, BR> PartialOrd<SubtreePathBuilder<'br, BR>> for SubtreePath<'bl, BL> 156 + impl<'br, BL, BR> PartialOrd<SubtreePathBuilder<'br, BR>> for SubtreePath<'_, BL> |

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path.rs:137:6 | 137 | impl<'bl, 'br, BL, BR> PartialOrd<SubtreePathBuilder<'br, BR>> for SubtreePathBuilder<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 137 - impl<'bl, 'br, BL, BR> PartialOrd<SubtreePathBuilder<'br, BR>> for SubtreePathBuilder<'bl, BL> 137 + impl<'br, BL, BR> PartialOrd<SubtreePathBuilder<'br, BR>> for SubtreePathBuilder<'_, BL> |

warning: doc list item without indentation --> costs/src/context.rs:182:5 | 182 | /// accumulator; | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 182 | /// accumulator; | +++

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path.rs:118:6 | 118 | impl<'bl, 'br, BL, BR> PartialOrd<SubtreePath<'br, BR>> for SubtreePath<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 118 - impl<'bl, 'br, BL, BR> PartialOrd<SubtreePath<'br, BR>> for SubtreePath<'bl, BL> 118 + impl<'br, BL, BR> PartialOrd<SubtreePath<'br, BR>> for SubtreePath<'_, BL> |

warning: the following explicit lifetimes could be elided: 'bl --> path/src/subtree_path.rs:101:6 | 101 | impl<'bl, 'br, BL, BR> PartialEq<SubtreePath<'br, BR>> for SubtreePath<'bl, BL> | ^^^ ^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes help: elide the lifetimes | 101 - impl<'bl, 'br, BL, BR> PartialEq<SubtreePath<'br, BR>> for SubtreePath<'bl, BL> 101 + impl<'br, BL, BR> PartialEq<SubtreePath<'br, BR>> for SubtreePath<'_, BL> |

warning: the following explicit lifetimes could be elided: 'b --> path/src/subtree_path.rs:55:6 | 55 | impl<'b, B: AsRef<[u8]>> Display for SubtreePath<'b, B> { | ^^ ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 55 - impl<'b, B: AsRef<[u8]>> Display for SubtreePath<'b, B> { 55 + impl<B: AsRef<[u8]>> Display for SubtreePath<'_, B> { |